Make ComponentDialog the default Dialog in DialogFragment [217618170]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Feb 3, 2022 12:19AM

ComponentDialog was added in https://issuetracker.google.com/205992875. It is a Dialog that interacts correctly with the OnBackPressedDispatcher. We should replace the Dialog in DialogFragment with ComponentDialog.

Comments

jb...@google.com <jb...@google.com> Feb 3, 2022 09:28PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Feb 3, 2022 11:14PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

jb...@google.com <jb...@google.com> #3Feb 4, 2022 12:03AM

Marked as fixed.

Great! Thanks a lot, I'll look for the live updates soon!

gs...@gmail.com <gs...@gmail.com> #4May 30, 2022 04:00PM

Should ComponentDialog be a part of DialogFragment's API as well?

requireActivity() returns a ComponentActivity so why does requireDialog() return a Dialog instead of a ComponentDialog? Also relevant to other APIs like onCreateDialog

[Deleted User] <[Deleted User]> #5Sep 12, 2022 01:57PM

I agree with the above comment. I don't want to have to cast my dialog to ComponentDialog in order to access OnBackPressedDispatcher.

Issue 217618170