Make ComponentDialog the default Dialog in DialogFragment [217618170]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Feb 3, 2022 12:19AM

ComponentDialog was added in https://issuetracker.google.com/205992875. It is a Dialog that interacts correctly with the OnBackPressedDispatcher. We should replace the Dialog in DialogFragment with ComponentDialog.

Comments

jb...@google.com <jb...@google.com> Feb 3, 2022 09:28PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Feb 3, 2022 11:14PM

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

jb...@google.com <jb...@google.com> #3Feb 4, 2022 12:03AM

Marked as fixed.

This has been added internally and will be available in the Fragment 1.5.0-alpha03 release.

gs...@gmail.com <gs...@gmail.com> #4May 30, 2022 04:00PM

Should ComponentDialog be a part of DialogFragment's API as well?

requireActivity() returns a ComponentActivity so why does requireDialog() return a Dialog instead of a ComponentDialog? Also relevant to other APIs like onCreateDialog

[Deleted User] <[Deleted User]> #5Sep 12, 2022 01:57PM

I agree with the above comment. I don't want to have to cast my dialog to ComponentDialog in order to access OnBackPressedDispatcher.

Issue 217618170