[Insets] Provide convenient way to partially apply insets [217768486]

Fixed

Feature Request

Status Update

No update yet.

Description

va...@google.com

created issue #1

Feb 3, 2022 09:51PM

All of the padding Modifiers current apply the entire insets of that type, which might not be desired.

For example, it's useful to apply the systemBars to the padding of a top app bar, but only the top, start and end.

In accompanist/insets, this was possible with Modifier.systemBarsPadding(bottom = false)

In the androidx.insets, the equivalent is possible, but much more verbose:

val density = LocalDensity.current
val layoutDirection = LocalLayoutDirection.current

Modifier.windowInsetsPadding(
    WindowInsets.systemBars.let {
        WindowInsets(
            left = it.getLeft(density, layoutDirection),
            top = it.getTop(density),
            right = it.getRight(density, layoutDirection)
        )
    }
)

Comments

ap...@google.com <ap...@google.com> #2Feb 14, 2022 05:00PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f48698b0f7d791cb705ac7b8c227102c93251a63
Author: George Mount <mount@google.com>
Date: Tue Feb 08 10:18:26 2022

Add "only()" WindowInsets method.

Fixes: 217768486

Relnote: "Add WindowInsets.only() method to allow developers
to include only dimensions from the WindowInsets."

Test: New tests
Change-Id: I14c94c017d0b7a31f5fc3248f478d5331332d18f

M compose/foundation/foundation-layout/api/restricted_current.txt
A compose/foundation/foundation-layout/src/test/kotlin/androidx/compose/foundation/layout/WindowInsetsTest.kt
M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/WindowInsets.kt
M compose/foundation/foundation-layout/api/current.txt
M compose/foundation/foundation-layout/build.gradle

https://android-review.googlesource.com/1976928

Issue 217768486

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Feb 14, 2022 05:00PM

Add comment

Issue metadata