Fixed
Status Update
Comments
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 9c2b4aad009a63212b3593630a12cb522102163d
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Feb 16 13:25:52 2022
Ensure deep links handle new line characters
Since new line characters are acceptable in URIs we should also support
them in deep links and actually match correctly.
This changed adds the Pattern.DOTALL flag to allow for escaped new line
characters.
RelNote: "NavDeepLinks now properly support encoding new line characters
meaning you pass multi-line routes/deep link URIs."
Test: NavDeepLinkTest
Bug: 217815060
Change-Id: I513d1fca7c3921bb3c3b006e3d88853a210bd204
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
https://android-review.googlesource.com/1988992
Branch: androidx-main
commit 9c2b4aad009a63212b3593630a12cb522102163d
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Feb 16 13:25:52 2022
Ensure deep links handle new line characters
Since new line characters are acceptable in URIs we should also support
them in deep links and actually match correctly.
This changed adds the Pattern.DOTALL flag to allow for escaped new line
characters.
RelNote: "NavDeepLinks now properly support encoding new line characters
meaning you pass multi-line routes/deep link URIs."
Test: NavDeepLinkTest
Bug: 217815060
Change-Id: I513d1fca7c3921bb3c3b006e3d88853a210bd204
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
jb...@google.com <jb...@google.com> #3
This has been fixed internally and will be available in the Navigation 2.4.2
and 2.5.0-alpha03
releases.
Description
Component used: Navigation Version used:
compose 1.1.0-rc03
& above;accompanist 0.22.1-rc
& above Devices/Android versions reproduced on: Oneplus7Pro Android Studio Version Android StudioBumblebee | 2021.1.1
Build #AI-211.7628.21.2111.8092744, built on January 19, 2022 Runtime version: 11.0.11+0-b60-7590822 x86_64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. macOS 12.1 GC: G1 Young Generation, G1 Old Generation Memory: 4096M Cores: 12 Registry: external.system.auto.import.disabled=true, ide.instant.shutdown=false Non-Bundled Plugins: cn.xiaoheiban.go-zero (1.0.0), com.c5inco.modifiers (0.1.11), org.plugin.dot.id (1.2), org.toml.lang (0.2.155.4114-211), PythonCore (211.7628.24), com.thoughtworks.gauge (211.6693.111), org.jetbrains.kotlin (211-1.6.10-release-923-AS7442.40), siosio.kodkod (2.0.4), org.intellij.plugins.markdown (211.7142.37)If this is a bug in the library, we would appreciate if you could attach:
App crashing if string nav arg consists
\n
even after encoding to%0A
and navigating to the route.Onclick of a button:-
Kindly check the sample project to trigger this issue
Exception:-