App crash if string argument in navArgs consists `\n` [217815060]

Fixed

Bug

Status Update

No update yet.

Description

ra...@gmail.com

created issue #1

Feb 4, 2022 05:51PM

Component used: Navigation Version used: compose 1.1.0-rc03 & above; accompanist 0.22.1-rc & above Devices/Android versions reproduced on: Oneplus7Pro Android Studio Version Android Studio Bumblebee | 2021.1.1 Build #AI-211.7628.21.2111.8092744, built on January 19, 2022 Runtime version: 11.0.11+0-b60-7590822 x86_64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. macOS 12.1 GC: G1 Young Generation, G1 Old Generation Memory: 4096M Cores: 12 Registry: external.system.auto.import.disabled=true, ide.instant.shutdown=false Non-Bundled Plugins: cn.xiaoheiban.go-zero (1.0.0), com.c5inco.modifiers (0.1.11), org.plugin.dot.id (1.2), org.toml.lang (0.2.155.4114-211), PythonCore (211.7628.24), com.thoughtworks.gauge (211.6693.111), org.jetbrains.kotlin (211-1.6.10-release-923-AS7442.40), siosio.kodkod (2.0.4), org.intellij.plugins.markdown (211.7142.37)

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

App crashing if string nav arg consists \n even after encoding to %0A and navigating to the route.

composable(
                            "profile?caption={caption}",
                            arguments = listOf(navArgument("caption") {
                                type = NavType.StringType
                                nullable = true
                            }) { ... }

Onclick of a button:-

val caption = "FirstLine\nSecondLine"
navController.navigate("profile?caption=${Uri.encode(caption)}")

Kindly check the sample project to trigger this issue

Exception:-

Process: com.ravi.navigationTest, PID: 11288
    java.lang.IllegalArgumentException: Navigation destination that matches request NavDeepLinkRequest{ uri=android-app://androidx.navigation/profile?caption=FirstLine%0ASecondLine } cannot be found in the navigation graph NavGraph(0x0) startDestination={Destination(0x78c6f587) route=Blue}
        at androidx.navigation.NavController.navigate(NavController.kt:1660)
        at androidx.navigation.NavController.navigate(NavController.kt:1980)
        at androidx.navigation.NavController.navigate$default(NavController.kt:1975)
        at com.ravi.navigationTest.ComposableSingletons$MainActivityKt$lambda-3$1$1$1$1$1.invoke(MainActivity.kt:58)
        at com.ravi.navigationTest.ComposableSingletons$MainActivityKt$lambda-3$1$1$1$1$1.invoke(MainActivity.kt:55)
        at androidx.compose.foundation.ClickableKt$clickable$4$gesture$1$2.invoke-k-4lQ0M(Clickable.kt:153)
        at androidx.compose.foundation.ClickableKt$clickable$4$gesture$1$2.invoke(Clickable.kt:142)
        at androidx.compose.foundation.gestures.TapGestureDetectorKt$detectTapAndPress$2$1$1.invokeSuspend(TapGestureDetector.kt:223)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:178)
        at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:166)
        at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:397)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:431)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:420)
        at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:328)
        at androidx.compose.ui.input.pointer.SuspendingPointerInputFilter$PointerEventHandlerCoroutine.offerPointerEvent(SuspendingPointerInputFilter.kt:511)
        at androidx.compose.ui.input.pointer.SuspendingPointerInputFilter.dispatchPointerEvent(SuspendingPointerInputFilter.kt:406)
        at androidx.compose.ui.input.pointer.SuspendingPointerInputFilter.onPointerEvent-H0pRuoY(SuspendingPointerInputFilter.kt:419)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:310)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:297)
        at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:297)
        at androidx.compose.ui.input.pointer.NodeParent.dispatchMainEventPass(HitPathTracker.kt:179)
        at androidx.compose.ui.input.pointer.HitPathTracker.dispatchChanges(HitPathTracker.kt:98)
        at androidx.compose.ui.input.pointer.PointerInputEventProcessor.process-BIzXfog(PointerInputEventProcessor.kt:80)
        at androidx.compose.ui.platform.AndroidComposeView.sendMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1159)
        at androidx.compose.ui.platform.AndroidComposeView.handleMotionEvent-8iAsVTc(AndroidComposeView.android.kt:1109)
        at androidx.compose.ui.platform.AndroidComposeView.dispatchTouchEvent(AndroidComposeView.android.kt:1059)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3143)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2814)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3143)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2814)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3143)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2814)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3143)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2814)
        at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:517)
        at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1894)
        at android.app.Activity.dispatchTouchEvent(Activity.java:4131)
        at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:475)
        at android.view.View.dispatchPointerEvent(View.java:14648)

NavigationTest.zip

310 KB

Download

Comments

jb...@google.com <jb...@google.com> Feb 16, 2022 10:24PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Feb 17, 2022 12:21AM

I believe I'm having a related problem on certain devices. I set the systemBarBehavior as seen in line below:

WindowInsetsControllerCompat(window, main_container).systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE

Although I'm setting the system bar behavior to BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE, it seems to be behaving as BEHAVIOR_SHOW_BARS_BY_TOUCH on some devices. After i hide the system UI (see fun below) then touch the screen the bottom system navigation bar appears (the status bar remains hidden). When i swipe down from the top, the system status bar does appear transparent and goes away after a few seconds but the bottom system nav bar remains and isn't transparent.

Bug appears on: Galaxy s9+ (android 10), Galaxy Note 10+ (android 10). Bug does not appear on: Google Pixel 3a (android 11), Google Pixel 3 (android 11). I haven't tested on any other devices besides Galaxy s6 but that phone has hardware buttons so it doesn't apply.

Here's my code to go into full screen mode:

// Hide the app action bar, system status bar and system navigation bar
private fun hideSystemUI() {
    supportActionBar?.hide()
    WindowCompat.setDecorFitsSystemWindows(window, false)
    WindowInsetsControllerCompat(window, main_container).let { controller ->
        controller.hide(WindowInsetsCompat.Type.statusBars() or WindowInsetsCompat.Type.navigationBars())
        controller.systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
    }
}

jb...@google.com <jb...@google.com> #3Feb 17, 2022 12:29AM

Marked as fixed.

Bug described above (where any touch on the screen reveals the bottom navigation bar) happens on Nokia 7.2 as well

Issue 217815060

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> Feb 16, 2022 10:24PM

ap...@google.com <ap...@google.com> #2Feb 17, 2022 12:21AM

jb...@google.com <jb...@google.com> #3Feb 17, 2022 12:29AM

Add comment

Issue metadata