IssueTracker

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link:      https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.foundation:foundation:1.8.0-alpha06
• androidx.compose.foundation:foundation-android:1.8.0-alpha06
• androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
• androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

Yes, this should be issue with any composable that is sibling to vertical divider inside intrinsic-min parent. Sorry for not being clear in report.

Any updates on this?

I'm pretty sure this is the bug behind this StackOverflow question too: https://stackoverflow.com/questions/77317620/aspectratio-modifier-breaks-min-vertical-sizing-of-containing-box

The intrinsic size calculation is wrong for some reasons (probably not passing in the proper constraints when calculating the intrinsic size of the children).

A simpler demo of the issue is:

@Preview(showBackground = true, widthDp = 300, heightDp = 400)
@Composable
fun TestRowCompose() {
    LazyColumn() {
        item {
            Row(
                modifier = Modifier
                    .height(intrinsicSize = IntrinsicSize.Min)
                    .background(Color.Magenta),
                verticalAlignment = Alignment.Top,
            ) {
                Text(text = "abcde", Modifier.fillMaxWidth(0.25f).background(Color.Red))
            }
        }
    }
}

I'm expecting the Magenta background to be the height of the Red backgorund, but instead it is bigger. It's actually as high as the text if each characters were rendered on their own line, which seems to indicate an improper constraints in width when measuring the minIntrinsicHeight for the Text.

Adding characters to the text grows the vertical height of the Purple background, which is unexpected.

Any updates on this?

Uchenna to take a look

This is actually a text bug. It has to do with the cache stopping the update from happening: MultiParagraphLayoutCache. It looks at whether the width has changed, and uses the cached value even though the value of the text has increased.

I tested out the sample here and it works fine with the intrinsic height increasing as needed vs when using Text.

Reassigning to Sean to take a look

Thanks for digging into this!

I suspect there may be two bugs stacked on top of each other based on history.

I'll fix the text over-caching issue quick and then we can see if the remaining intrinsics bug lingers.

Thanks!

Sean

Update: It looks like this was just a text issue I can't reproduce without text.

Fixing in aosp/2962173

Any hope this fix will make it into a 1.6.x release?

Trying to get it into 1.6.2

Yep, it's heading in to 1.6.2.

Thanks for asking! Was able to make the cut :)

Since hotpatching and linking to this bug - adding notes.

This bug applied if any of the following conditions were met:

1. Text was selectable (selection container is not null)
2. Text is annotated string
3. onTextLayoutResult callback is not null

The "simple text" path (which exists for optimization reasons) did not have this bug. Notably TextStringSimpleNode / Paragraph cache was already invalidating correctly. As a result, this could appear as a heisenbug depending on how you've coded your application.

To force the issue if it is appearing randomly in your app, the easiest way would be to ensure you always pass an AnnotatedString for all Text/BasicText that you're debugging.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.foundation:foundation:1.6.2
• androidx.compose.foundation:foundation-android:1.6.2
• androidx.compose.foundation:foundation-desktop:1.6.2
• androidx.compose.foundation:foundation:1.7.0-alpha03
• androidx.compose.foundation:foundation-android:1.7.0-alpha03
• androidx.compose.foundation:foundation-desktop:1.7.0-alpha03

Thanks for including it into 1.6.2, which allows me to fix an annoying display bug!