Status Update
No update yet.
Comments
le...@gmail.com
Branch: androidx-main
commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022
Deprecate all the APIs in textclassifier
Bug: 210509084
Test: Check api/current.txt and ensure all classes are deprecated
Relnote: "Deprecate all the APIs in the textclassifier module"
Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java
nj...@google.com
lp...@google.com
so...@google.com
Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.
le...@gmail.com
I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.
po...@google.com
an...@google.com
Branch: androidx-main
commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022
Bump textclassifier for final release and turn-down
Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi
M libraryversions.toml
ma...@hopper.com
Bugjuggler: wait until 2022-03-23
sz...@gmail.com
ma...@google.com
Is there a replacement or should we just abandon TextClassifier for android older than API Level 26 ?
uo...@google.com
Abandon. The owning team had no plans to release a replacement library.
se...@google.com
Thanks for digging into this!
se...@google.com
I suspect there may be two bugs stacked on top of each other based on history.
I'll fix the text over-caching issue quick and then we can see if the remaining intrinsics bug lingers.
Thanks!
Sean
se...@google.com
Update: It looks like this was just a text issue I can't reproduce without text.
Fixing in aosp/2962173
ap...@google.com
Branch: androidx-main
commit e9ef4f948b25c55dd15eecf31476b287fd3966d8
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Feb 13 16:58:34 2024
Don't cache intrinsicHeight through text changes
Only applies to annotatedstring / layout result implementation
Fixes:
Test: ./gradlew :com:found:found:cAT
Change-Id: Ied047b99122e43d1a0c088f742fe090df5c0c4c2
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt
mt...@gmail.com
Any hope this fix will make it into a 1.6.x release?
se...@google.com
Trying to get it into 1.6.2
se...@google.com
Yep, it's heading in to 1.6.2.
Thanks for asking! Was able to make the cut :)
se...@google.com
Since hotpatching and linking to this bug - adding notes.
This bug applied if any of the following conditions were met:
- Text was selectable (selection container is not null)
- Text is annotated string
- onTextLayoutResult callback is not null
The "simple text" path (which exists for optimization reasons) did not have this bug. Notably TextStringSimpleNode / Paragraph cache was already
To force the issue if it is appearing randomly in your app, the easiest way would be to ensure you always pass an AnnotatedString for all Text/BasicText that you're debugging.
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.6.2androidx.compose.foundation:foundation-android:1.6.2androidx.compose.foundation:foundation-desktop:1.6.2androidx.compose.foundation:foundation:1.7.0-alpha03androidx.compose.foundation:foundation-android:1.7.0-alpha03androidx.compose.foundation:foundation-desktop:1.7.0-alpha03
mt...@gmail.com
Thanks for including it into 1.6.2, which allows me to fix an annoying display bug!
Description
Description has been deleted.