Assigned
Status Update
Comments
co...@google.com <co...@google.com>
dy...@gmail.com <dy...@gmail.com> #2
This is a hard one. We can't easily read native crashes from that Motorola device since their system image is not public. I assume you can't reproduce this either, but if possible can you try using WorkManager 2.0.0 or 1.0.1-rc01? This would help track down the possible changes that might have introduced this issue. Thanks!
li...@gmail.com <li...@gmail.com> #3
We actually did reproduce it, the current store version of Pocket Casts has WorkManager 2.0.0 and this bug if you want to try and test something. I will try 1.0.1-rc01 and report back.
se...@google.com <se...@google.com> #4
Is there a difference between 1.0.1 and 2.0.1? We tried 2.0.1 and it was crashing, if there is a difference I can try 1.0.1 but I thought they were the same?
dy...@gmail.com <dy...@gmail.com> #5
Can you also describe how you trigger the bug and which devices manifest the problem? Is it just running the app? Is it doing something specific?
dy...@gmail.com <dy...@gmail.com> #6
We are testing on a Moto X running Android 6.0 but our play store report shows numerous motorola devices are crashing as the attached screenshots show. We just downloaded a bunch of episodes (which uses workmanager) and eventually it started crashing, it would then crash at start up every time.
se...@google.com <se...@google.com>
se...@google.com <se...@google.com> #7
So to answer your earlier question, 1.0.1 should be equivalent but I think there may be some small differences in Room between 1.0 and 2.0 and since this crash seems related to Room, that's why we were asking if you could check to see if you can reproduce it on 1.x.
Regarding the initial crash, do you have any logs for that?
Regarding the initial crash, do you have any logs for that?
dy...@gmail.com <dy...@gmail.com> #8
This is the log I have. Hope it helps. Will test 1.0.1 for you
an...@steadfastinnovation.com <an...@steadfastinnovation.com> #9
The logs are too short its just the crash and not much else before. :(
If the phone happens to be rooted and you are OK with sharing DB queries then you can enable SQL logging so we can see the queries that are occurring:
adb shell setprop log.tag.SQLiteStatements VERBOSE
adb shell stop
adb shell start
It would also be great if you can send us a bigger set of logs, or even better yet a bugreport after the crash occurs. (https://developer.android.com/studio/debug/bug-report )
If the phone happens to be rooted and you are OK with sharing DB queries then you can enable SQL logging so we can see the queries that are occurring:
adb shell setprop log.tag.SQLiteStatements VERBOSE
adb shell stop
adb shell start
It would also be great if you can send us a bigger set of logs, or even better yet a bugreport after the crash occurs. (
[Deleted User] <[Deleted User]> #10
We can't root the phone sorry, we might be able to send a bug report though
se...@google.com <se...@google.com>
ju...@appsoluts.de <ju...@appsoluts.de> #11
We have a bug report from the crash already actually
c....@gmail.com <c....@gmail.com> #12
We haven't been able to get the crash to happen on 1.0.1 so far
an...@steadfastinnovation.com <an...@steadfastinnovation.com> #13
With a version of WorkManager that you are able to reproduce the issue, can you try adding Room 2.1.0-alpha06 as a dependency, effectively upgrading WorkManager's runtime dependency of Room?
Can you also enable WorkManager logs using setMinimumLoggingLevel(Log.DEBUG)https://developer.android.com/topic/libraries/architecture/workmanager/advanced/custom-configuration
If you observe the crash please do take a bug report. If possible also dump dbinfo for the app's package: adb shell dumpsys dbinfo <package-name>
Can you also enable WorkManager logs using setMinimumLoggingLevel(Log.DEBUG)
If you observe the crash please do take a bug report. If possible also dump dbinfo for the app's package: adb shell dumpsys dbinfo <package-name>
se...@google.com <se...@google.com> #14
We have gone back to 2.0.0 and haven't been able to make it crash again unfortunately. Will keep trying. We are rolling out an update next week that reverts to 1.0.0 and will let you know if the crash goes away in production as well
c....@gmail.com <c....@gmail.com> #15
I just want to distinguish between which versions you are using/experiencing this on.
1. The bug title lists 2.0.0
2. The first update lists 2.0.1-rc01
3. #14 lists 2.0.0
Can you reproduce at all with any version of WorkManager 2.x at this point? And if so, which ones work and which ones don't?
1. The bug title lists 2.0.0
2. The first update lists 2.0.1-rc01
3. #14 lists 2.0.0
Can you reproduce at all with any version of WorkManager 2.x at this point? And if so, which ones work and which ones don't?
co...@hm.com <co...@hm.com> #16
Our store version had 2.0.0 and is what the screenshots come from, we reproduced locally using that. We upgraded to 2.0.1rc1 and the phone was still crashing. We downgraded to 1.0.0 and the crash went away. To help with this testing we went back to 2.0.0 to try and get it to crash again but we haven't been able to get it to happen again.
Description
Material 3 comes with some new principles. One of them is Design Tokens . According to the short description on the Material website:
This fits what all files in this package are. Unfortunately, the
Material3
library marks them as being internal, which unnecessarily complicates the work for developers using Material You.While some of the tokens in the package linked above are dedicated to some specific components such as OutlinedCardTokens , some other Design Tokens are important and should not be marked as internal. This includes but is not limited to: ColorSchemeKeyTokens , ElevationTokens , TypographyKeyTokens , etc. And of course, this also includes functions that use these tokens such as the ColorSchemeKeyTokens.toColor() extension function.
These Design Tokens are important for developers applying custom styles to some components. Changing the typography of a Text component already means "applying a custom style." If I, as a developer, want to create a
CustomComponent
by following the Material You guidelines, I would create aCustomComponentTokens
object, and I would add the default values of myCustomComponent
in there. Unfortunately,MaterialTheme.colorScheme.background
can only be called from a@Composable
function. There are a couple of other alternatives; some developers would add the default values directly in the parameter of the Composable function, and some other developers would duplicate theColorSchemeKeyTokens
object andColorSchemeKeyTokens.toColor()
function.The point is, defining everything as
internal
is a bad practice. It favors inconsistencies between different projects based on Material 3 and with the Material3 library itself. Please consider avoiding thisinternal
trend, there's still time forMaterial3
.