API changes in drawer for large screens [218286829]

Feature Request

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Feb 7, 2022 11:05AM

We need to adjust the API of drawers to make better adapt to the large screen navigation.

This also includes making a new API that are non-existent right now - permanent drawer, slideable/standard drawers, and DrawerItem, similar to the items we provides out of the box for BottomNav and NavRail

Comments

ap...@google.com <ap...@google.com> #2Feb 14, 2022 12:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit d1aba6064d4c1aedfd10ec75fd8d181fcb37c947
Author: Matvei Malkov <malkov@google.com>
Date: Mon Feb 07 18:31:52 2022

Missing pieces for adaptive compose material3: drawer items

material3 provides navigation rail with items, bottom navigation with items, but the drawer without items, evven though there are specs for it.

This CL add a NavigationDrawerItem and some related APIs around it

Bug: 218286829
Test: will be added
Relnote: NavigationDrawerItem is added that represents a single destination within the drawers
Change-Id: Ic396fe99d1f26080a3e3a9d2ed505e72008c85aa

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/NavigationDrawerItemScreenshotTest.kt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/NavigationDrawerItemTest.kt

https://android-review.googlesource.com/1974464

ap...@google.com <ap...@google.com> #3Feb 14, 2022 12:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit ec4e83f16c8a226c381001b61679a0ff189d4dcb
Author: Matvei Malkov <malkov@google.com>
Date: Mon Feb 07 17:29:43 2022

Missing pieces for adaptive compose material3: drawers for large screens

This CL adds two different kinds of drawer specifically for large screens: permanent standard drawer and dismissible standard drawer.

Bug: 218286829
Relnote: PermanentNavigationDrawer and DismissibleNavigationDrawer have been added as experiental APIs. Those are the drawers suitable well for large screen devices.
Test: added new for new API
Change-Id: I5f8abcd6137f0819ceccae0f8cacd2a44af5ad2e

A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/PermanentNavigationDrawerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/DismissibleNavigationDrawerTest.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt

https://android-review.googlesource.com/1974463

ap...@google.com <ap...@google.com> #4Feb 14, 2022 12:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7825d1e6ed228729519f9312ee73c5f4a99d5634
Author: Matvei Malkov <malkov@google.com>
Date: Tue Feb 01 16:15:36 2022

Missing pieces for adaptive compose material3: drawer rename

This CL renames NavigationDrawer to ModalNavigationDrawer to better explain its modal nature, better align with the material guidelines and also leave the room for other drawers to be developeed (PermanentNavigationDrawer, Slideable/StandardNavigationDrawer).

Bug: 218286829
Test: tested demos + tested the replaceWith statemenet
Relnote: NavigationDrawer has been renamed to ModalNavigationDrawer
Change-Id: I1807d3c889c63efa7a569416daaed58d94a3b17a

M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalNavigationDrawerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalNavigationDrawerScreenshotTest.kt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt

https://android-review.googlesource.com/1966681

ma...@google.com <ma...@google.com> #5Feb 14, 2022 12:15PM

Reassigned to ni...@google.com.

All APIs have landed. The only thing left is to replace TODOs in documentation with the proper images.

Over to Nick to do it and then close.

go...@gmail.com <go...@gmail.com> #6May 15, 2022 07:23AM

There's still an issue with DismissibleNavigationDrawer.

When expanded, I expect: the body region should be resized to fit in the smaller remaining screen space. What actually happens: the body remains the same size meaning that it is partly missing from the screen.

is...@google.com <is...@google.com> Jan 25, 2023 03:54PM

Status: New

du...@gmail.com <du...@gmail.com> #7Sep 14, 2023 07:50AM

Could any one talk about the feature: fix the width of the drawer in DismissibleNavigationDrawer ?

for now, the drawer is as width as the screen. (360dp at most)
If I set a width to the drawerContent(Modifier.width(150.dp)), the main content was offset a distance to the left of the screen.

Message last modified on Sep 14, 2023 07:52AM

fi...@gmail.com <fi...@gmail.com> #8Nov 25, 2024 05:56PM

If the drawer menu is open, the content is not resized it move towards how to fix this issue.

Screenshot_20241125_230813.png

1.1 MB

View

Download