Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt - M
compose/foundation/foundation/api/restricted_current.txt - M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt - M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt - M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
ap...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06androidx.compose.foundation:foundation-android:1.8.0-alpha06androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
ap...@google.com
Branch: androidx-main
commit 7825d1e6ed228729519f9312ee73c5f4a99d5634
Author: Matvei Malkov <malkov@google.com>
Date: Tue Feb 01 16:15:36 2022
Missing pieces for adaptive compose material3: drawer rename
This CL renames NavigationDrawer to ModalNavigationDrawer to better explain its modal nature, better align with the material guidelines and also leave the room for other drawers to be developeed (PermanentNavigationDrawer, Slideable/StandardNavigationDrawer).
Bug: 218286829
Test: tested demos + tested the replaceWith statemenet
Relnote: NavigationDrawer has been renamed to ModalNavigationDrawer
Change-Id: I1807d3c889c63efa7a569416daaed58d94a3b17a
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalNavigationDrawerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalNavigationDrawerScreenshotTest.kt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
ma...@google.com
All APIs have landed. The only thing left is to replace TODOs in documentation with the proper images.
Over to Nick to do it and then close.
go...@gmail.com
There's still an issue with DismissibleNavigationDrawer.
When expanded, I expect: the body region should be resized to fit in the smaller remaining screen space. What actually happens: the body remains the same size meaning that it is partly missing from the screen.
is...@google.com
du...@gmail.com
for now, the drawer is as width as the screen. (360dp at most)
If I set a width to the drawerContent(Modifier.width(150.dp)), the main content was offset a distance to the left of the screen.
fi...@gmail.com
If the drawer menu is open, the content is not resized it move towards how to fix this issue.
Description
We need to adjust the API of drawers to make better adapt to the large screen navigation.
This also includes making a new API that are non-existent right now - permanent drawer, slideable/standard drawers, and DrawerItem, similar to the items we provides out of the box for BottomNav and NavRail