Art / Dalvik VMs prior to version 8 does not support the fix for JDK-8272564 [218298666]

Verified

Bug

Status Update

No update yet.

Description

sg...@google.com

created issue #1

Feb 7, 2022 01:51PM

D8 and R8 rewritings will be required to undo the fix for JDK-8272564.

Comments

sg...@google.com <sg...@google.com> #2Feb 7, 2022 03:41PM

Fixed in r1313.

ap...@google.com <ap...@google.com> #3Feb 8, 2022 12:16PM

[Empty comment from Monorail migration]

ap...@google.com <ap...@google.com> #4Feb 8, 2022 02:48PM

[Empty comment from Monorail migration]

ap...@google.com <ap...@google.com> #5Feb 9, 2022 07:24AM

This issue was migrated from

crbug.com/nativeclient/245?no_tracker_redirect=1

[Monorail components: TrustedRT]

sg...@google.com <sg...@google.com> Apr 28, 2022 06:45AM

Marked as fixed.

ap...@google.com <ap...@google.com> #6Apr 28, 2022 03:30PM

Project: r8
Branch: main

commit f657b216abf893ecf1908fc48f98a3409d1cc0c8
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Apr 28 17:29:20 2022

Strenghten the check for the Art JDK-8272564 workaround

Also add a test of invalid invokes not changing.

Bug:

b/218298666

Change-Id: I9ab27dad52a04808b54ddaa37eccf7c4aaa9deaa

A src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564InvalidCode.java
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java

https://r8-review.googlesource.com/68128

sg...@google.com <sg...@google.com> #7Apr 29, 2022 08:27AM

Verified by sg...@google.com.

Changing this to P1, as fixes for this should be merged to release channels so they are prepared for javac JDK-18 code. Even with -target 11 javac from JDK-18 will generate this code.

Message last modified on Apr 29, 2022 08:28AM

ap...@google.com <ap...@google.com> #8Apr 29, 2022 08:53AM

Project: r8
Branch: 3.2

commit 21c0036aa502a840d0f91a6900c7a7ba029788f1
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Apr 29 10:24:43 2022

Version 3.2.60

Bug:

b/218298666

Change-Id: I8850398fbea4a8047b2fd740cd59f54aabe0ace7

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/68139

ap...@google.com <ap...@google.com> #9Apr 29, 2022 08:53AM

Project: r8
Branch: 3.2

commit 1100490d661d94cdd0d2a8c5ddc4eaf4f95f881e
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Apr 29 10:00:06 2022

Add missing method

Strenghten the check for the Art JDK-8272564 workaround

Also add a test of invalid invokes not changing.

Merge issue:
Added new method from

https://r8-review.googlesource.com/c/r8/+/65403/9/src/main/java/com/android/tools/r8/graph/DexDefinitionSupplier.java#79

Bug:

b/218298666

https://r8-review.googlesource.com/68137

ap...@google.com <ap...@google.com> #10Apr 29, 2022 08:53AM

Project: r8
Branch: 3.2

commit 9b8e2ecb73d882af622f4ab214922579f2c14110
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Apr 29 09:58:43 2022

Rewrite code from javac code with for JDK-8272564

Some Dalvik and Art MVs does not support interface invokes to Object
members not explicitly defined on the symbolic reference of the
interface invoke. In these cases rewrite to a virtual invoke with
the symbolic reference java.lang.Object.

Conflicts:
Removed tests during cherry-pick. They used JDK-18 which is not
in third_party on the 3.2 branch.

Bug: 218298666
Change-Id: I38abdea8d9bbf4d004be1877373b58de161a55a7

M src/main/java/com/android/tools/r8/graph/DexItemFactory.java
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java

https://r8-review.googlesource.com/68136

ap...@google.com <ap...@google.com> #11Apr 29, 2022 09:42AM

Project: r8
Branch: 3.3

commit f807a15c6b3df1f3f7f7e728e3998b988060f2b1
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Apr 29 11:07:47 2022

Version 3.3.35

Bug:

b/218298666

Change-Id: Idcfd34d11baa7318ed5bd44c9e7e6a0eb9197f07

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/68141

ap...@google.com <ap...@google.com> #12Apr 29, 2022 09:42AM

Project: r8
Branch: 3.3

commit 4fbd93fbe54fd98cb36dd195e11c3a8343dc9d58
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Apr 29 11:07:28 2022

Strenghten the check for the Art JDK-8272564 workaround

Also add a test of invalid invokes not changing.

Bug:

b/218298666

https://r8-review.googlesource.com/68140

ap...@google.com <ap...@google.com> #13Apr 29, 2022 09:42AM

Project: r8
Branch: 3.1

commit fe489dbb2e2df8bb500745fdbbff1e1a3751064c
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Apr 29 11:28:37 2022

Version 3.1.74

Bug:

b/218298666

Change-Id: I35911f7fd661385fc90d74adb449831eb104ce5d

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/68145

ap...@google.com <ap...@google.com> #14Apr 29, 2022 09:42AM

Project: r8
Branch: 3.1

commit 72532b2fe5a8623eaa016f9fb14522c3ad853b32
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Apr 29 11:28:11 2022

Strenghten the check for the Art JDK-8272564 workaround

Also add a test of invalid invokes not changing.

Bug:

b/218298666

https://r8-review.googlesource.com/68143

ap...@google.com <ap...@google.com> #15Apr 29, 2022 09:42AM

Project: r8
Branch: 3.1

commit b49442885c0b272ad1ccd2d821d4f7b781775489
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Apr 29 11:21:35 2022

Rewrite code from javac code with for JDK-8272564

Some Dalvik and Art MVs does not support interface invokes to Object
members not explicitly defined on the symbolic reference of the
interface invoke. In these cases rewrite to a virtual invoke with
the symbolic reference java.lang.Object.

Conflicts:
Removed tests during cherry-pick. They used JDK-18 which is not
in third_party on the 3.1 branch.

Merge issue:
Added new method from

https://r8-review.googlesource.com/c/r8/+/65403/9/src/main/java/com/android/tools/r8/graph/DexDefinitionSupplier.java#79
Added code from

https://r8-review.googlesource.com/c/r8/+/63660/4/src/main/java/com/android/tools/r8/graph/DexItemFactory.java#1373

https://r8-review.googlesource.com/c/r8/+/63660/4/src/main/java/com/android/tools/r8/graph/DexItemFactory.java#1390

Bug: 218298666
Change-Id: I38abdea8d9bbf4d004be1877373b58de161a55a7

M src/main/java/com/android/tools/r8/graph/DexItemFactory.java
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/main/java/com/android/tools/r8/graph/DexDefinitionSupplier.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java

https://r8-review.googlesource.com/68142

ap...@google.com <ap...@google.com> #16Apr 29, 2022 09:43AM

b/218298666

https://r8-review.googlesource.com/68140

ap...@google.com <ap...@google.com> #17May 6, 2022 09:41AM

Project: r8
Branch: 3.2

commit 666fcef6b74bc1e527fa06a6c6903feff9eadc36
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 06 10:58:50 2022

Negate condition to correctly match name

Bug: 218298666
Change-Id: Id8bf2048af36c8c07ce07b5bfd35ed766f555a52

M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java

https://r8-review.googlesource.com/68286

ap...@google.com <ap...@google.com> #18May 6, 2022 09:41AM

Project: r8
Branch: 3.1

commit 3c7b6516575c3eb979ff640abcc60ea70f1fa8e2
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 06 11:03:26 2022

Negate condition to correctly match name

Bug: 218298666
Change-Id: Id8bf2048af36c8c07ce07b5bfd35ed766f555a52

M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java

https://r8-review.googlesource.com/68290

ap...@google.com <ap...@google.com> #19May 6, 2022 09:42AM

https://r8-review.googlesource.com/68286

de...@google.com <de...@google.com> #20May 13, 2022 07:52PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Beta 1 (2021.3.1.10)
Android Gradle Plugin 7.3.0-beta01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

jk...@gmail.com <jk...@gmail.com> #21Jun 11, 2022 05:56PM

Good level it back

ca...@gmail.com <ca...@gmail.com> #22Jul 8, 2022 02:08AM

yunusemrecftc16@gmail.com

qo...@gmail.com <qo...@gmail.com> #23Jul 9, 2022 02:23AM

Good

Issue 218298666

Description

Issue summary

Comments

sg...@google.com <sg...@google.com> #2Feb 7, 2022 03:41PM

ap...@google.com <ap...@google.com> #3Feb 8, 2022 12:16PM

ap...@google.com <ap...@google.com> #4Feb 8, 2022 02:48PM

ap...@google.com <ap...@google.com> #5Feb 9, 2022 07:24AM

sg...@google.com <sg...@google.com> Apr 28, 2022 06:45AM

ap...@google.com <ap...@google.com> #6Apr 28, 2022 03:30PM

sg...@google.com <sg...@google.com> #7Apr 29, 2022 08:27AM

ap...@google.com <ap...@google.com> #8Apr 29, 2022 08:53AM

ap...@google.com <ap...@google.com> #9Apr 29, 2022 08:53AM

ap...@google.com <ap...@google.com> #10Apr 29, 2022 08:53AM

ap...@google.com <ap...@google.com> #11Apr 29, 2022 09:42AM

ap...@google.com <ap...@google.com> #12Apr 29, 2022 09:42AM

ap...@google.com <ap...@google.com> #13Apr 29, 2022 09:42AM

ap...@google.com <ap...@google.com> #14Apr 29, 2022 09:42AM

ap...@google.com <ap...@google.com> #15Apr 29, 2022 09:42AM

ap...@google.com <ap...@google.com> #16Apr 29, 2022 09:43AM

ap...@google.com <ap...@google.com> #17May 6, 2022 09:41AM

ap...@google.com <ap...@google.com> #18May 6, 2022 09:41AM

ap...@google.com <ap...@google.com> #19May 6, 2022 09:42AM

de...@google.com <de...@google.com> #20May 13, 2022 07:52PM

jk...@gmail.com <jk...@gmail.com> #21Jun 11, 2022 05:56PM

ca...@gmail.com <ca...@gmail.com> #22Jul 8, 2022 02:08AM

qo...@gmail.com <qo...@gmail.com> #23Jul 9, 2022 02:23AM

Add comment

Issue metadata