Status Update
Comments
sg...@google.com <sg...@google.com> #2
Branch: main
commit 77b38bac8b835605eb4858334278b12933c007a4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 11:41:49 2022
Consult api database during type strengthening
Bug:
Change-Id: I9e070782a2da544eba90b15c41d5b7281142cc3b
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningAboveMinApiTest.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
ap...@google.com <ap...@google.com> #3
Branch: 3.2
commit b6be4ce67ec9f9389dab9e8f4cac1b7bd97f38ca
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:46:55 2022
Version 3.2.69
Bug:
Change-Id: I6aa6dabc3902e9fa1cd5b8289ed3cbf0ba2a0548
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #4
Branch: 3.2
commit 3cc0c8b3d67cc20bf6c1a8401871b6847bf792c6
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:46:41 2022
Consult api database during type strengthening
Bug:
Change-Id: I9e070782a2da544eba90b15c41d5b7281142cc3b
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningAboveMinApiTest.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
ap...@google.com <ap...@google.com> #5
Branch: 3.3
commit d1de9e74d3e4a847b89bf0b822bfd227e51be2e9
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:35:35 2022
Version 3.3.61
Bug:
Change-Id: Ic9c7674b0240eaac8ea94698f8806a5faf349cf3
M src/main/java/com/android/tools/r8/Version.java
sg...@google.com <sg...@google.com>
ap...@google.com <ap...@google.com> #6
Branch: 3.3
commit 6b77d23ac1cbe5a201b4ec8f9c29ed59d438d1d1
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:33:24 2022
Consult api database during type strengthening
Bug:
Change-Id: I9e070782a2da544eba90b15c41d5b7281142cc3b
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningAboveMinApiTest.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
sg...@google.com <sg...@google.com> #7
Branch: 3.2
commit 3cc0c8b3d67cc20bf6c1a8401871b6847bf792c6
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:46:41 2022
Consult api database during type strengthening
Bug:
Change-Id: I9e070782a2da544eba90b15c41d5b7281142cc3b
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningAboveMinApiTest.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
ap...@google.com <ap...@google.com> #8
Thanks for testing out R8 3.3. This should now be fixed in 3.3.61.
ap...@google.com <ap...@google.com> #9
I'm still seeing this after 3.3.61. I'll share a dump over email
ap...@google.com <ap...@google.com> #11
Branch: main
commit eb0ee8c2fc5a4fb328bc509a174bdc1fa0b3b8fb
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 24 19:30:20 2022
Consult api database for parameter type strengthening
Bug:
Change-Id: I86f622807ae0bc7e77bf63566606ef5b4708b8bf
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
ap...@google.com <ap...@google.com> #12
Branch: 3.3
commit 981a1edf73a6977c77857d85cad9409f22093ce5
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Jun 27 08:33:50 2022
Version 3.3.67
Bug:
Change-Id: I1f46f8b1f5119ffc7257adaa384ad548125e1197
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #13
Branch: 3.3
commit 00cb17cc2fe36a3ef23dc4736051da67c91d537d
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Jun 27 08:32:51 2022
Consult api database for parameter type strengthening
Bug:
Change-Id: I86f622807ae0bc7e77bf63566606ef5b4708b8bf
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
ap...@google.com <ap...@google.com> #14
Fix for parameter types landed in 3.3.67.
ap...@google.com <ap...@google.com> #15
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Dolphin Beta 5 (2021.3.1.14)
- Android Gradle Plugin 7.3.0-beta05
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
ap...@google.com <ap...@google.com> #16
Branch: 3.3
commit 4fbd93fbe54fd98cb36dd195e11c3a8343dc9d58
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Apr 29 11:07:28 2022
Strenghten the check for the Art JDK-8272564 workaround
Also add a test of invalid invokes not changing.
Bug:
Change-Id: I9ab27dad52a04808b54ddaa37eccf7c4aaa9deaa
A src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564InvalidCode.java
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
ap...@google.com <ap...@google.com> #17
Branch: 3.2
commit 666fcef6b74bc1e527fa06a6c6903feff9eadc36
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 06 10:58:50 2022
Negate condition to correctly match name
Bug: 218298666
Change-Id: Id8bf2048af36c8c07ce07b5bfd35ed766f555a52
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
ap...@google.com <ap...@google.com> #18
Branch: 3.1
commit 3c7b6516575c3eb979ff640abcc60ea70f1fa8e2
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 06 11:03:26 2022
Negate condition to correctly match name
Bug: 218298666
Change-Id: Id8bf2048af36c8c07ce07b5bfd35ed766f555a52
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
ap...@google.com <ap...@google.com> #19
Branch: 3.2
commit 666fcef6b74bc1e527fa06a6c6903feff9eadc36
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 06 10:58:50 2022
Negate condition to correctly match name
Bug: 218298666
Change-Id: Id8bf2048af36c8c07ce07b5bfd35ed766f555a52
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
de...@google.com <de...@google.com> #20
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Dolphin Beta 1 (2021.3.1.10)
- Android Gradle Plugin 7.3.0-beta01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
jk...@gmail.com <jk...@gmail.com> #21
Good level it back
Description
D8 and R8 rewritings will be required to undo the fix for JDK-8272564.