FR: Update WorkRequest [219446409]

Fixed

Feature Request

Status Update

No update yet.

Description

se...@google.com

created issue #1

Feb 14, 2022 11:17AM

WM should provide an ability to update WorkSpec in non-intrusive way, meaning:

don't cancel work if it is already running.
calculate period delay / initial delay from the original enqueue (not from the update time)

Currently it is impossible to implement outside of WM, because we don't expose enqueue time.

Comments

ap...@google.com <ap...@google.com> #2Mar 25, 2022 06:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ap...@google.com <ap...@google.com> #3Apr 4, 2022 04:57PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Apr 4, 2022 04:57PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ap...@google.com <ap...@google.com> #5Apr 5, 2022 06:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9d5b985fd5b1e65c2e0f2593d10eb956f1c80580
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 17:43:51 2022

Restrict schedulers to cancel only their own work.

Previously schedulers were able to cancel a work that
they haven't started. E.g. `CommandHandler` on cancel
signal were calling "stopWork(workId)" unconditionally,
no matter if it actually started that work or not

bug: 219446409
Test: refactoring
Change-Id: Ia48e3239c3302d7b6ff1114c3baa52a62a40ee32

M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/CommandHandler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-testing/src/main/java/androidx/work/testing/TestScheduler.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
A work/work-runtime/src/main/java/androidx/work/impl/WorkRunId.kt
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/StartWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java

https://android-review.googlesource.com/2052907

ap...@google.com <ap...@google.com> #6Apr 7, 2022 09:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit c8f83d8b1fe59a51ab60124c1604b7f9b83bac78
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Apr 07 19:13:33 2022

Improve implementation note on WorkRunId

bug: 219446409
Test: NA
Change-Id: If923e68aefba620c97a1e9373351e67d813df765

M work/work-runtime/src/main/java/androidx/work/impl/WorkRunId.kt

https://android-review.googlesource.com/2057643

ap...@google.com <ap...@google.com> #7Jun 12, 2022 04:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit b1e1b4714f013edda06df4b0c92d18c28e5b958d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed May 25 11:51:51 2022

Use WorkSpec in ConstraintsTracker

Going forward generation will be added to WorkSpec,
so it is important to know constraints for which
workspec exactly were met.

bug: 219446409
Test: Refactoring
Change-Id: I9beb5bc1a0345380daaf4fa2c1974eab213c9577

M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/controllers/ConstraintControllerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.kt

https://android-review.googlesource.com/2115798

ap...@google.com <ap...@google.com> #8Jun 13, 2022 05:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit a7d319b96a0622fcc9219ad4b156e4fafa215fa5
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 13 17:02:04 2022

Rename `WorkRunId` to `StartStopToken`

bug: 219446409
Test: refacting
Change-Id: I312ad14013d9931ec485fbccee27048ad697479c

M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/StartStopToken.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/CommandHandler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-testing/src/main/java/androidx/work/testing/TestScheduler.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/StartWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java

https://android-review.googlesource.com/2123382

ap...@google.com <ap...@google.com> #9Jun 14, 2022 10:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1430b5a035fb33c4464e24396c547cf1efa9bbb3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 13 15:03:55 2022

Read WorkSpec in advance in Processor

It is important for updates of periodic workers,
because in case of periodic workers workspec could be
updated during the run of the worker. So Worker should
have all required information at the moment of the start
in order to stay consistent.

bug: 219446409
Test: refactoring
Change-Id: I6a29381b20919cda88461c2960b74dd0b7107a26

M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkContinuationImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt

https://android-review.googlesource.com/2123378

ap...@google.com <ap...@google.com> #10Jun 14, 2022 10:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit 66fe06e58187191981ba3f17c8ac8e015a2aae26
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 06 14:37:30 2022

Introduce generation in WorkSpec

This was done in a preparation for updates of
WorkSpecs. It is important for a Worker to know
for which generation it was started:
otherwise it can lead to inconsistent runs,
e.g. old constraints were met and started a new
Worker.

bug: 219446409
Test: ProcessorTests
Change-Id: I2bf26fd7b0d368943a5d119a4183bbaf7a27ae64

M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
A work/work-runtime/src/schemas/androidx.work.impl.WorkDatabase/16.json
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
M work/work-testing/src/main/java/androidx/work/testing/TestScheduler.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/ForceStopRunnableTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemjob/SystemJobServiceTest.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/WorkTimer.java
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfo.kt
M work/work-gcm/src/androidTest/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/ExecutionListener.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/WorkForegroundUpdater.java
M work/work-runtime/src/main/java/androidx/work/impl/StartStopToken.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/CommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobInfoConverter.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/GcmTaskConverter.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/workers/DiagnosticsWorker.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/AlarmsTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/Alarms.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/WorkTimerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplLargeExecutorTest.java

https://android-review.googlesource.com/2115799

ap...@google.com <ap...@google.com> #11Jun 23, 2022 11:14PM

Project: platform/frameworks/support
Branch: androidx-main

commit e5de8cabaccc7a7ee8aaee8e6cb3e85da3be3212
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Mar 31 16:52:26 2022

Initial commit for update work feature

Current implementation only updates `OneTimeWorkRequest`-s

Relnote: "`WorkManager.updateWork` was added to update work
preserving its original enqueue time and chaining.
Currently it supports only OneTimeWorkRequests."

bug: 219446409
Test: WorkUpdateTest

Change-Id: I9a2489e50d217cf70377d348b183ceb2d777506d

A work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/WorkManager.java
M work/work-runtime/api/current.txt
A work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/api/restricted_current.ignore
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/work-runtime/api/current.ignore
A work/work-runtime/src/androidTest/java/androidx/work/impl/testutils/TestConstraints.kt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.kt

https://android-review.googlesource.com/2051581

ap...@google.com <ap...@google.com> #12Jun 28, 2022 12:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit 75331425fcf02b5fb681a796a369a11325a86154
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 27 23:56:01 2022

Use correct WorkSpec in SystemForegroundDispatcher

Database can potentially have newer version of worker,
so we should rely on the spec of running worker instead.

Test: SystemForegroundDispatcherTest
bug: 219446409
Change-Id: I6144f1e604996407d51a92c1fb7e9a6c64577a92

M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java

https://android-review.googlesource.com/2137872

ap...@google.com <ap...@google.com> #13Jun 30, 2022 10:59AM

Project: platform/frameworks/support
Branch: androidx-main

commit bc2bc2a8efff9d46a2a070c4b11067b46a24279b
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Jun 29 12:11:20 2022

Read tags along with WorkSpec in Processor

Otherwise due to the race, tags can be inconsistent
with the rest of properties of worker.

Test: WorkUpdateTest
bug: 219446409
Change-Id: Ieca7c5e1650a5ca16c643ca0b800a7ad2c984951

M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkContinuationImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt

https://android-review.googlesource.com/2139532

ap...@google.com <ap...@google.com> #14Jul 7, 2022 04:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit b75f2a988f93a687bd95c87ebdb6ec1d486c4f3c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Jul 07 16:39:25 2022

Preserve lastEnqueueTime during the update

Test: WorkUpdateTest
bug: 219446409
Change-Id: Ifdc6a4c105ee2c53b2538265f933fd02634e85c5

M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt

https://android-review.googlesource.com/2148159

ap...@google.com <ap...@google.com> #15Jul 12, 2022 10:48AM

Project: platform/frameworks/support
Branch: androidx-main

commit 3258084eefb45350a75e43d86798f2e757ba49a3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jul 11 17:26:07 2022

Use ConstraintTrackingWorker in WorkManager.update

Test: WorkUpdateTest
bug: 219446409
Change-Id: Icbb073c77b5f529cb599d11ad74f4f8899eddbb4

M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
A work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueUtils.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt

https://android-review.googlesource.com/2149993

ap...@google.com <ap...@google.com> #16Jul 13, 2022 11:19AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4110a2f8612edcd105a72640d43b9c9ae00e727d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Jul 08 15:52:39 2022

Introduce ExistingPeriodicWorkPolicy.Update

It is very similar to previously existing
ExistingPeriodicWorkPolicy.REPLACE.

Test: WorkManagerImplTest + integration test-app
Relnote: "`ExistingPeriodicWorkPolicy.UPDATE` was
added. This policy allows to update a periodic work
by the name. It is similar existing `REPLACE`, but
is less intrusive: it doesn't cancel a worker if it
is currently running, it preserves enqueue time, so
initial delay and period are calculated from original
enqueue time, rather than update time. `REPLACE` was
deprecated to decrease a confusion between very similarly
named `REPLACE`and `UPDATE`. If you still want to keep
previous semantics of `REPLACE`,
newly added `CANCEL_AND_REENQUEUE` identical to `REPLACE`
can be used."
bug: 219446409

Change-Id: I985edc2cf7ac7c316932185f3fd0a3ca6660f2dc

M work/work-multiprocess/src/main/java/androidx/work/multiprocess/RemoteWorkManagerImpl.java
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/RemoteWorkManagerClient.java
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/aidl/androidx/work/multiprocess/IWorkManagerImpl.aidl
M work/work-runtime/api/current.txt
M work/integration-tests/testapp/src/main/res/layout/activity_main.xml
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/api/restricted_current.txt
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RemoteService.kt
M work/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml

https://android-review.googlesource.com/2149093

ap...@google.com <ap...@google.com> #17Aug 10, 2022 03:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8e22db3e7a62008ab0c4c07ac3f682e0c1cc4dbf
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Aug 08 15:39:16 2022

Add WorkerParameters.getGeneration

Relnote: """
`WorkerParameters.getGeneration()` was added that returns
a generation of a worker. A worker has multiple generations, if it was updated via
`WorkManager.updateWork` or `WorkManager.enqueueUniquePeriodicWork` using
`ExistingPeriodicWorkPolicy.UPDATE`.
This worker can possibly be of an older generation rather than latest known,
if an update has happened while this worker is running."""
bug: 219446409

Test: WorkUpdateTest#updateWorkerParameterGeneration
Change-Id: I128a9838067f3a1722a9460f52ef58fb0f98136c

M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkerParameters.java
M work/work-rxjava2/src/test/java/androidx/work/RxWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxForegroundInfoTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxWorkerTest.kt
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/SetCompletableProgressTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime-ktx/src/androidTest/java/androidx/work/CoroutineWorkerTest.kt
M work/work-testing/src/main/java/androidx/work/testing/TestListenableWorkerBuilder.java
M work/work-runtime/api/current.txt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-rxjava2/src/test/java/androidx/work/RxForegroundInfoTest.kt
M work/work-runtime/api/restricted_current.txt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/DefaultWorkerFactoryTest.java
M work/work-runtime/src/androidTest/java/androidx/work/DelegatingWorkerFactoryTest.kt
M work/work-rxjava2/src/test/java/androidx/work/SetCompletableProgressTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkForegroundRunnableTest.kt
M work/work-runtime/src/main/java/androidx/work/WorkerParameters.java

https://android-review.googlesource.com/2177783

dr...@gmail.com <dr...@gmail.com> #18Aug 12, 2022 05:17PM

I like the ability introduced in 2.8.0-alpha03 to update an existing work request, particularly a periodic work request.

I see that there is a new ExistingPeriodicWorkPolicy.UPDATE type as well as a new WorkManager.updateWork() method.

Can I ask: what is the difference between setting up a new work request and calling enqueueUniquePeriodicWork() (with the same name as the existing work request, and also passing ExistingPeriodicWorkPolicy.UPDATE as the work policy), versus calling updateWork() and passing the existing work request itself?

ap...@google.com <ap...@google.com> #19Aug 15, 2022 03:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit cb25671d1f6f60aa0baf13e39a66496b28540915
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Aug 11 15:21:26 2022

Add generation to WorkerInfo

Relnote: """
`WorkerInfo.getGeneration()` was added that returns
a generation of a worker. A worker has multiple generations, if it was updated via
`WorkManager.updateWork` or `WorkManager.enqueueUniquePeriodicWork` using
`ExistingPeriodicWorkPolicy.UPDATE`.
If the worker is currently running, it can possibly be of an older generation rather than
returned by this methof if an update has happened during an execution of this worker."""
bug: 219446409
Test: WorkUpdateTest

Change-Id: I665c5d480700dd682d1268ee88be124783fca70f

M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkInfo.java
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/ParcelableWorkInfoTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/WorkInfo.java
M work/work-runtime/api/current.txt

https://android-review.googlesource.com/2183459

se...@google.com <se...@google.com> Aug 15, 2022 03:09PM

Marked as fixed.

na...@google.com <na...@google.com> #20Sep 12, 2022 05:52PM

This bug was linked in a change in the following release(s):

androidx.work:work-multiprocess:2.8.0-alpha04
androidx.work:work-rxjava2:2.8.0-alpha04
androidx.work:work-rxjava3:2.8.0-alpha04

IssueTracker