ConcurrentModificationException on trying to reverse a mutableStateListOf [219554654]

Fixed

Bug

Status Update

No update yet.

Description

ph...@gmail.com

created issue #1

Feb 15, 2022 06:38AM

Jetpack Compose release version: 1.1.0 & 1.2.0-alpha03

Here's a sample code to reproduce the issue:

val list = remember { List(100) { it }.toMutableStateList() }
LaunchedEffect(Unit) {
    delay(1.seconds)
    list.reverse()
}
Text(list.toList().toString())

A crash occurs with the next stack trace:

java.util.ConcurrentModificationException
    at androidx.compose.runtime.snapshots.StateListIterator.validateModification(SnapshotStateList.kt:278)
    at androidx.compose.runtime.snapshots.StateListIterator.set(SnapshotStateList.kt:271)
    at java.util.Collections.reverse(Collections.java:435)
    at kotlin.collections.CollectionsKt___CollectionsJvmKt.reverse(_CollectionsJvm.kt:43)
    at com.example.composeplayground.MainActivityKt$TestScreen$1$1.invokeSuspend(MainActivity.kt:748)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
    at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.kt:81)
    at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch(AndroidUiDispatcher.android.kt:41)
    at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.run(AndroidUiDispatcher.android.kt:57)
    at android.os.Handler.handleCallback(Handler.java:938)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loopOnce(Looper.java:201)
    at android.os.Looper.loop(Looper.java:288)
    at android.app.ActivityThread.main(ActivityThread.java:7842)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Comments

ry...@google.com <ry...@google.com> Feb 22, 2022 10:14AM

Assigned to je...@google.com.

ch...@google.com <ch...@google.com> Sep 9, 2022 10:24PM

Reassigned to ch...@google.com.

ah...@gmail.com <ah...@gmail.com> #2Sep 13, 2023 01:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit ed4cbc0c50bb906d78cc1617be5ad7fcb14c56f5
Author: Oscar Adame Vázquez <oscarad@google.com>
Date: Wed Jan 17 13:54:01 2024

Add Alignment parameter to animateContentSize

Note that it actually adds a new function altogether to fit existing
use cases where the trailing lambda causes the API to be inflexible
(can't add parameters before or after the lambda).

Relnote: "Added alignment parameter to` Modifier.animateContentSize()`."

Bug: 269803907
Test: AnimationModifierTest.testAlignmentInAnimateContentSize
Change-Id: I5623af336f137bb4464cbf7993942452e86bcd88

M compose/animation/animation/api/current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/src/androidInstrumentedTest/kotlin/androidx/compose/animation/AnimationModifierTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimationModifier.kt

https://android-review.googlesource.com/2915193

ch...@google.com <ch...@google.com> #3Sep 14, 2023 11:02PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.animation:animation:1.7.0-alpha03
androidx.compose.animation:animation-android:1.7.0-alpha03
androidx.compose.animation:animation-desktop:1.7.0-alpha03

ap...@google.com <ap...@google.com> #4Sep 15, 2023 07:49PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 75f720e1695c3574930d0385211341fac876a834
Author: Chuck Jazdzewski <chuckj@google.com>
Date: Thu Sep 14 15:22:33 2023

Relax concurrent modification exception for snapshot state list

The snapshot state list iterator considered any change made outside the
iterator as a concurrent change. This change relaxes the checking to
only consider structural changes (adding and removing) to be treated as
a concurrent change. This allows SnapshotStateList to be used with
`reverse()` which assumes that setting the value of an element is not a
concurrent change.

Adds RandomeAccess interface to MutableStateList to signal collection
extensions functions they can use direct indexing versions of their
algorithm.

Corrects the set() after a call previous() to update the correct
element.

Fixes: 219554654
Test: ./gradlew :compose:r:r:tDUT
Relnote: """SnapshotStateList is not marked as RandomAccess to enable
the direct indexing version of list helpers to be used"

Change-Id: I5210ca5c0f490619381ecf93ac0b1ccb03071e36

M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/snapshots/SnapshotStateList.kt
M compose/runtime/runtime/src/nonEmulatorCommonTest/kotlin/androidx/compose/runtime/snapshots/SnapshotStateListTests.kt

https://android-review.googlesource.com/2751617

IssueTracker