Fixed
Status Update
No update yet.
Comments
al...@google.com
dy...@gmail.com
We have got to get a better way to handle deprecations. This is awful.
ca...@google.com
va...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 387ce59c6290b334c790f270d98f1b1dde5d3391
Author: Alan Viverette <alanv@google.com>
Date: Wed Nov 29 11:26:23 2023
Clean up obsolete compat methods in ViewCompat and usages in core
Doesn't update lint baseline yet because there are lots of unrelated
changes there. We'll handle the baseline after we clean up the rest of
core.
Doesn't update usages outside of core or core-ktx. These should be
handled by individual library owners.
Bug: 313834577
Test: ViewCompatTest
Relnote: Deprecated obsolete compat methods in ViewCompat
Change-Id: I0bfc2cd15dc681ba0c09f795d25622f2ade004d6
M core/core-ktx/src/main/java/androidx/core/view/View.kt
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/view/ViewCompat.java
M development/build_log_simplifier/messages.ignore
https://android-review.googlesource.com/2852865
Branch: androidx-main
commit 387ce59c6290b334c790f270d98f1b1dde5d3391
Author: Alan Viverette <alanv@google.com>
Date: Wed Nov 29 11:26:23 2023
Clean up obsolete compat methods in ViewCompat and usages in core
Doesn't update lint baseline yet because there are lots of unrelated
changes there. We'll handle the baseline after we clean up the rest of
core.
Doesn't update usages outside of core or core-ktx. These should be
handled by individual library owners.
Bug: 313834577
Test: ViewCompatTest
Relnote: Deprecated obsolete compat methods in ViewCompat
Change-Id: I0bfc2cd15dc681ba0c09f795d25622f2ade004d6
M core/core-ktx/src/main/java/androidx/core/view/View.kt
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/view/ViewCompat.java
M development/build_log_simplifier/messages.ignore
ap...@google.com
Holding off until Sergey is done to avoid conflicts. He's way ahead of me on minSdk cleanup.
va...@google.com
Sergey, do you want to use this bug for your minSdk-related CLs and then reassign to me when you're done? Or just reassign to me when you're done.
dy...@gmail.com
I think I'm done with removing RequiresApi-s.
Description
Component used:
androidx.core:core-ktxVersion used:
1.8.0-alpha04Devices/Android versions reproduced on: Pixel 6 Pro/A13-DP1, Pixel 3XL/A12
Short Description:
Window.getDecorView()can no longer be used to get theWindowInsetsControllerCompatas the function always return null.Explanation: In the version
1.8.0-alpha03ofandroidx.core:core,WindowInsetsControllerCompatnow fully depends on a View as seen inViewCompat.getWindowInsetsController(View)function now relies on the rootView's layout params to determine whether if it's an instance ofWindowManager.LayoutParams, and if not,nullis returned (the previous implementation did not rely on the layout params). When passingdecorViewin the new function,getLayoutParamsreturns null, so because it isn't an instance ofWindowManager.LayoutParams,ViewCompat.getWindowInsetsController(decoreView)always returns null too.