[WindowInsetsControllerCompat] ViewCompat.getWindowInsetsController always return null [219572936]

Fixed

Bug

Status Update

No update yet.

Description

dy...@gmail.com

created issue #1

Feb 15, 2022 03:42PM

Component used: androidx.core:core-ktx

Version used: 1.8.0-alpha04

Devices/Android versions reproduced on: Pixel 6 Pro/A13-DP1, Pixel 3XL/A12

Short Description: Window.getDecorView() can no longer be used to get the WindowInsetsControllerCompat as the function always return null.

Explanation: In the version 1.8.0-alpha03 of androidx.core:core, WindowInsetsControllerCompat now fully depends on a View as seen in I29264. More importantly, following that change, the ViewCompat.getWindowInsetsController(View) function now relies on the rootView's layout params to determine whether if it's an instance of WindowManager.LayoutParams, and if not, null is returned (the previous implementation did not rely on the layout params). When passing decorView in the new function, getLayoutParams returns null, so because it isn't an instance of WindowManager.LayoutParams, ViewCompat.getWindowInsetsController(decoreView) always returns null too.

InsetsControllerBugDemo.zip

103 KB

Download

Comments

al...@google.com <al...@google.com> Feb 15, 2022 04:09PM

Reassigned to ca...@google.com.

dy...@gmail.com <dy...@gmail.com> #2Feb 15, 2022 08:23PM

Or when changing to textView.textMetricsParamsCompat still crash.

private fun setAsyncText(textView: AppCompatTextView, text: String?) {
if (!text.isNullOrEmpty()) {
val textFuture = PrecomputedTextCompat.getTextFuture(text!!, textView.textMetricsParamsCompat, null)
textView.setTextFuture(textFuture) //Crash
}
}

ca...@google.com <ca...@google.com> Feb 16, 2022 01:28PM

Reassigned to va...@google.com.

va...@google.com <va...@google.com> #3Feb 16, 2022 06:16PM

add this line :
textView.setLayoutDirection(ViewCompat.getLayoutDirection(textView));
before :
setTextFuture(....)

ap...@google.com <ap...@google.com> #4Feb 28, 2022 07:27PM

Thanks, #3. It worked.

But I think it is better when set before this line
val textFuture = PrecomputedTextCompat.getTextFuture(text!!, textView.textMetricsParamsCompat, null)

Set android:layoutDirection="locale" or android:layoutDirection="inherit" for AppCompatTextView in the XML layout didn't this problem.

The new method btw re-set layoutDirector. Weird! This should handle in the AppcompatTextView.

private fun setAsyncText(textView: AppCompatTextView, text: String?) {
if (!text.isNullOrEmpty()) {
textView.layoutDirection = textView.layoutDirection
val textFuture = PrecomputedTextCompat.getTextFuture(text!!, textView.textMetricsParamsCompat, null)
textView.setTextFuture(textFuture) //Crash
}
}

va...@google.com <va...@google.com> #5Feb 28, 2022 07:56PM

Marked as fixed.

Sorry. I forgot the info.

minSdk 21
targetSdk 28

Thanks #3 again.

dy...@gmail.com <dy...@gmail.com> #6Feb 28, 2022 08:04PM

App Crash at
TextViewCompat.java:889
if (!param.equals(precomputed.getParams())) {
throw new IllegalArgumentException("Given text can not be applied to TextView.");
}
PrecomputedTextCompat.class:334
with : this.mTextDir != other.getTextDirection() == true
So,
TextDirection on TextView and TextDirection on Param is difference
maybe, it handled wrong or missing conditional on getTextDirectionHeuristic of TextViewCompat