Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 7b83f482e3cab0d7126e66a6dbeb1645dffc27aa
Author: Dustin Lam <dustinlam@google.com>
Date: Wed Jul 13 19:24:27 2022
Commonize SparseArrayCompat
Bug: 219589118
Fixes: 228347315
Test: ./gradlew collection:collection:test
Relnote: "Make SparseArrayCompat available to non-jvm platforms"
Change-Id: Ic9bd08bed81ddc1d902fc9947d6b3f8e5bb4c45f
M collection/collection/api/current.txt
M collection/collection/src/commonMain/kotlin/androidx/collection/SparseArrayCompat.kt
A collection/collection/src/jvmMain/kotlin/androidx/collection/SparseArrayCompat.jvm.kt
D collection/collection/src/jvmTest/java/androidx/collection/SparseArrayCompatTest.java
M collection/collection/src/commonMain/kotlin/androidx/collection/SparseArray.kt
A collection/collection/src/commonTest/kotlin/androidx/collection/SparseArrayCompatTest.kt
A collection/collection/src/jvmTest/java/androidx/collection/SparseArrayCompatJvmTest.kt
M collection/collection/api/public_plus_experimental_current.txt
M collection/collection/api/restricted_current.txt
M collection/collection/build.gradle
A collection/collection/src/nativeMain/kotlin/androidx/collection/SparseArrayCompat.native.kt
https://android-review.googlesource.com/2151732
Branch: androidx-main
commit 7b83f482e3cab0d7126e66a6dbeb1645dffc27aa
Author: Dustin Lam <dustinlam@google.com>
Date: Wed Jul 13 19:24:27 2022
Commonize SparseArrayCompat
Bug: 219589118
Fixes: 228347315
Test: ./gradlew collection:collection:test
Relnote: "Make SparseArrayCompat available to non-jvm platforms"
Change-Id: Ic9bd08bed81ddc1d902fc9947d6b3f8e5bb4c45f
M collection/collection/api/current.txt
M collection/collection/src/commonMain/kotlin/androidx/collection/SparseArrayCompat.kt
A collection/collection/src/jvmMain/kotlin/androidx/collection/SparseArrayCompat.jvm.kt
D collection/collection/src/jvmTest/java/androidx/collection/SparseArrayCompatTest.java
M collection/collection/src/commonMain/kotlin/androidx/collection/SparseArray.kt
A collection/collection/src/commonTest/kotlin/androidx/collection/SparseArrayCompatTest.kt
A collection/collection/src/jvmTest/java/androidx/collection/SparseArrayCompatJvmTest.kt
M collection/collection/api/public_plus_experimental_current.txt
M collection/collection/api/restricted_current.txt
M collection/collection/build.gradle
A collection/collection/src/nativeMain/kotlin/androidx/collection/SparseArrayCompat.native.kt
Description
In order to isolate redundant methods / hacks for JVM source + binary compatibility, we should split classes into expect / actuals with the hacks only added to the JVM actual implementation.
Many of these additions were only necessary to keep compatibility with collections when implemented in Java, such as for property translation of isEmpty() -> .isEmpty when uses in Kotlin.