WindowInsetsControllerCompat.isAppearanceLightStatusBars always returns false [219993701]

Fixed

Bug

Status Update

No update yet.

Description

pa...@gmail.com

created issue #1

Feb 17, 2022 02:40PM

Component used: androidx.core:core-ktx

Version used: 1.8.0-alpha04

Devices/Android versions reproduced on: PIXEL 5/A12

Short Description: windowInsetsController.isAppearanceLightStatusBars always returns false.

Explanation: When I'm trying to get the default isAppearanceLightStatusBars value it always returns false for the first time for both Light and Dark theme. So I am forced to use deprecated way to determine this value:

private fun isAppearanceLightStatusBars(): Boolean {
    return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
        (window.decorView.systemUiVisibility and View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR) != 0
    } else {
        false
    }
}

TestLightStatusBar.zip

16 MB

Download

Comments

al...@google.com <al...@google.com> Feb 17, 2022 04:30PM

Reassigned to ca...@google.com.

al...@google.com <al...@google.com> #2Apr 7, 2022 09:23PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

va...@google.com <va...@google.com> #3Apr 14, 2022 09:16PM

Can you see if this issue is still present in version 1.8.0-alpha07? The implementation has changed a bit since 1.8.0-alpha04, so it's possible this was resolved.

al...@google.com <al...@google.com> #4Apr 14, 2022 09:28PM

I'm working internally, so would it be possible to update the version there?

Edit: Discussed offline

Message last modified on Apr 14, 2022 10:34PM

va...@google.com <va...@google.com> #5May 5, 2022 12:13AM

It looks like the issue here is querying isAppearanceLightStatusBars on API 30 and above when the value hasn't been set by WindowInsetsControllerCompat itself, likely due to:

https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/view/InsetsController.java;l=1577;drc=65ba861856ef0fb72075da0e1fba9b353019ea07

A potential workaround is to rely on internal platform behavior, and flip the flag stopping the real value being reported with something like window.insetsController?.setSystemBarsAppearance(0, 0). Even though the mask is zero (meaning no appearance has changed), that method has the side-effect of flipping the controlled flag: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/view/ViewRootInsetsControllerHost.java;l=172;drc=090c0cbcb0f71576669ec58cb72148659ffe0083

va...@google.com <va...@google.com> May 6, 2022 08:47PM

Accepted by va...@google.com.

ro...@veeva.com <ro...@veeva.com> #6Aug 1, 2023 11:27AM

After more than 1 year this is still an issue. Can we please add the workaround from #5 to WindowCompat?

Message last modified on Aug 1, 2023 11:28AM

al...@google.com <al...@google.com> #7Mar 14, 2024 07:19PM

Assigned to rg...@google.com.

Reassigning to current owner per go/androidx/owners.

al...@google.com <al...@google.com> #8Mar 14, 2024 09:17PM

Reassigned to jj...@google.com.

Re-triaging by request.

va...@google.com <va...@google.com> Mar 14, 2024 11:18PM

Accepted by va...@google.com.

ap...@google.com <ap...@google.com> #9Mar 20, 2024 04:21PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit ec9dcf2d9b05266d6a7e8001b255a0db83e85545
Author: Alex Vanyo <vanyo@google.com>
Date: Thu May 05 21:42:04 2022

Fix retrieving initial system bar appearance on API 30+

Fixes: 219993701
Test: New tests

Change-Id: I1859688c4d89fa7c365eb420fb1646af0b7cd7db

M core/core/src/androidTest/AndroidManifest.xml
A core/core/src/androidTest/java/androidx/core/view/DarkSystemBarsActivity.java
A core/core/src/androidTest/java/androidx/core/view/LightSystemBarsActivity.java
A core/core/src/androidTest/java/androidx/core/view/ThemeSystemBarsTest.kt
M core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt
M core/core/src/androidTest/res/values/styles.xml
M core/core/src/main/java/androidx/core/view/WindowInsetsControllerCompat.java

https://android-review.googlesource.com/2089023