Bug P2
Status Update
Comments
kl...@google.com <kl...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt
- M
compose/foundation/foundation/api/restricted_current.txt
- M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
- M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
sp...@gmail.com <sp...@gmail.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
to...@gmail.com <to...@gmail.com> #4
Any word on this or good workarounds for windowSoftInputMode="adjustResize"? I tried some of the ones from the basic text field issue tracker and came up with the following which is good most of the time, but it being delay based is gonna be unacceptable. It can be unreliable on some devices or when there is a heavy load:
@OptIn(ExperimentalFoundationApi::class)
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContent {
val listState = rememberLazyListState()
val bringIntoViewRequester = remember { BringIntoViewRequester() }
val coroutineScope = rememberCoroutineScope()
var pinnedHandle: PinnableContainer.PinnedHandle? by remember { mutableStateOf(null) }
MaterialTheme {
Surface {
LazyColumn(
modifier = Modifier.fillMaxSize(),
state = listState
) {
items(count = 20) {
val pinnableContainer = LocalPinnableContainer.current
AndroidView(
modifier = Modifier
.fillMaxWidth()
.bringIntoViewRequester(bringIntoViewRequester),
factory = { context ->
EditText(context).apply {
setText("$it")
onFocusChangeListener = View.OnFocusChangeListener { _, hasFocus ->
if (hasFocus) {
pinnedHandle = pinnableContainer?.pin()
coroutineScope.launch {
delay(200)
bringIntoViewRequester.bringIntoView()
}
} else {
pinnedHandle?.release()
pinnedHandle = null
}
}
}
}
)
}
}
}
}
}
}
Description
The
onFocusChildPositioned
API introduced in aosp/1965665 currently ONLY works when the focused child is in the same composable, and does not work if the focused child is anAndroidView
or inside anAndroidView
, even if it's another composition inside theAndroidView
.This is because this API was required to fix an issue in the foundation module, and because it's new and still
@Experimental
needed to live in the foundation module. TheAndroidView
wiring is all done in the ui module however, and we don't allow cross-module experimental dependencies, so the android wiring couldn't happen yet.