Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit bfdd111df98ae51af5266573ad915bfc006bb7bf
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Jun 06 15:17:45 2023
Cleanup method tracing implementation in Macrobenchmark.
* No longer requires the use of `:benchmark:benchmark-internal`.
* Relies on `androidx.benchmark.profiling.mode` set to `MethodTracing`.
* Correctly handles process cold starts, given we use `am start --start-profiler <FILE> -W <INTENT>`.
Relnote: "
Provides the ability to generate method traces as a result of running a Macrobenchmark
using the following test instrumentation arguments.
```groovy
android {
defaultConfig {
testInstrumentationRunnerArguments [
'androidx.benchmark.profiling.mode': 'MethodTracing',
// Other arguments
]
}
}
```
"
Test: Ran TrivialStartupBenchmark + added unit tests.
Bug: b/285912360
Change-Id: I7ad37bee17646cfef1564c9f0c84d20923d63ed9
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Arguments.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
D benchmark/benchmark-internal/build.gradle
D benchmark/benchmark-internal/src/main/AndroidManifest.xml
D benchmark/benchmark-internal/src/main/java/androidx/benchmark/internal/MethodTracingReceiver.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoSdkHandshakeTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
M benchmark/integration-tests/macrobenchmark-target/build.gradle
M settings.gradle
https://android-review.googlesource.com/2617495
Branch: androidx-main
commit bfdd111df98ae51af5266573ad915bfc006bb7bf
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Jun 06 15:17:45 2023
Cleanup method tracing implementation in Macrobenchmark.
* No longer requires the use of `:benchmark:benchmark-internal`.
* Relies on `androidx.benchmark.profiling.mode` set to `MethodTracing`.
* Correctly handles process cold starts, given we use `am start --start-profiler <FILE> -W <INTENT>`.
Relnote: "
Provides the ability to generate method traces as a result of running a Macrobenchmark
using the following test instrumentation arguments.
```groovy
android {
defaultConfig {
testInstrumentationRunnerArguments [
'androidx.benchmark.profiling.mode': 'MethodTracing',
// Other arguments
]
}
}
```
"
Test: Ran TrivialStartupBenchmark + added unit tests.
Bug:
Change-Id: I7ad37bee17646cfef1564c9f0c84d20923d63ed9
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Arguments.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
D benchmark/benchmark-internal/build.gradle
D benchmark/benchmark-internal/src/main/AndroidManifest.xml
D benchmark/benchmark-internal/src/main/java/androidx/benchmark/internal/MethodTracingReceiver.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoSdkHandshakeTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
M benchmark/integration-tests/macrobenchmark-target/build.gradle
M settings.gradle
Description
Take an argument to BaselineProfileRule to allow apps to pass multiple package prefixes for filtering (for library test app use case).