Status Update
Comments
vi...@google.com <vi...@google.com>
ba...@google.com <ba...@google.com> #2
Branch: main
commit 77b38bac8b835605eb4858334278b12933c007a4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 11:41:49 2022
Consult api database during type strengthening
Bug:
Change-Id: I9e070782a2da544eba90b15c41d5b7281142cc3b
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningAboveMinApiTest.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
ba...@google.com <ba...@google.com> #3
Branch: 3.2
commit b6be4ce67ec9f9389dab9e8f4cac1b7bd97f38ca
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:46:55 2022
Version 3.2.69
Bug:
Change-Id: I6aa6dabc3902e9fa1cd5b8289ed3cbf0ba2a0548
M src/main/java/com/android/tools/r8/Version.java
ol...@motionmetrics.co <ol...@motionmetrics.co> #4
Branch: 3.2
commit 3cc0c8b3d67cc20bf6c1a8401871b6847bf792c6
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:46:41 2022
Consult api database during type strengthening
Bug:
Change-Id: I9e070782a2da544eba90b15c41d5b7281142cc3b
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningAboveMinApiTest.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
ba...@google.com <ba...@google.com> #5
Branch: 3.3
commit d1de9e74d3e4a847b89bf0b822bfd227e51be2e9
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:35:35 2022
Version 3.3.61
Bug:
Change-Id: Ic9c7674b0240eaac8ea94698f8806a5faf349cf3
M src/main/java/com/android/tools/r8/Version.java
ba...@google.com <ba...@google.com> #6
Branch: 3.3
commit 6b77d23ac1cbe5a201b4ec8f9c29ed59d438d1d1
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:33:24 2022
Consult api database during type strengthening
Bug:
Change-Id: I9e070782a2da544eba90b15c41d5b7281142cc3b
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningAboveMinApiTest.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
ol...@motionmetrics.co <ol...@motionmetrics.co> #7
Branch: 3.2
commit 3cc0c8b3d67cc20bf6c1a8401871b6847bf792c6
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:46:41 2022
Consult api database during type strengthening
Bug:
Change-Id: I9e070782a2da544eba90b15c41d5b7281142cc3b
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningAboveMinApiTest.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
ol...@motionmetrics.co <ol...@motionmetrics.co> #8
Thanks for testing out R8 3.3. This should now be fixed in 3.3.61.
[Deleted User] <[Deleted User]> #9
I'm still seeing this after 3.3.61. I'll share a dump over email
su...@google.com <su...@google.com>
ol...@motionmetrics.co <ol...@motionmetrics.co> #11
Branch: main
commit eb0ee8c2fc5a4fb328bc509a174bdc1fa0b3b8fb
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 24 19:30:20 2022
Consult api database for parameter type strengthening
Bug:
Change-Id: I86f622807ae0bc7e77bf63566606ef5b4708b8bf
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
lk...@gmail.com <lk...@gmail.com> #12
Branch: 3.3
commit 981a1edf73a6977c77857d85cad9409f22093ce5
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Jun 27 08:33:50 2022
Version 3.3.67
Bug:
Change-Id: I1f46f8b1f5119ffc7257adaa384ad548125e1197
M src/main/java/com/android/tools/r8/Version.java
ol...@motionmetrics.co <ol...@motionmetrics.co> #13
Branch: 3.3
commit 00cb17cc2fe36a3ef23dc4736051da67c91d537d
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Jun 27 08:32:51 2022
Consult api database for parameter type strengthening
Bug:
Change-Id: I86f622807ae0bc7e77bf63566606ef5b4708b8bf
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
ol...@motionmetrics.co <ol...@motionmetrics.co> #14
Fix for parameter types landed in 3.3.67.
ra...@google.com <ra...@google.com>
ol...@motionmetrics.co <ol...@motionmetrics.co> #15
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Dolphin Beta 5 (2021.3.1.14)
- Android Gradle Plugin 7.3.0-beta05
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
ha...@google.com <ha...@google.com> #16
Hi Oliver and all reporters:
This is fixed in
Please update to Android 15 Beta and verify.
Thank you!
ol...@motionmetrics.co <ol...@motionmetrics.co> #17
Hello! This is fantastic news. I see this bug report referenced in the Android 15 beta 2 release notes. Would it be possible to clarify what the fixes contain? Is GATT-133 still a thing, or has it been replaced with more descriptive errors? Is there improved documentation on the Bluetooth app, or has it been open sourced?
Re verification, we will have to wait and see how this plays out. GATT_133 is something that we have been unable to reproduce in a controlled environment, however we capture analytics on it so will be able to see if these fixes improve the situation over time.
Many thanks! Olly
Description
We have issues with GATT_133 connection errors in our app. They're fairly common, and don't seem to be the fault of anything our app is doing, but i'm happy to be proven wrong here.
It seems other companies (eg square ) with ble peripherals have the same issues as they all seem to have support pages explaining how to clear the bluetooth app cache.
Clearing the bluetooth app cache is the only (fairly) reliable way we've found to mitigate these issues, but its a terrible UX.
I've attached a screenshot of our analytics data showing unique customers who experience this issue per device - you can see pixels are at the top there.
I understand this may be too generic a report to actively work on as reproducing it is impossible, however this is an 'issue' tracker, and this is a very widespread issue in the android ecosystem.
One actionable outcome which would help developers in future, is to improve the error reporting in the bluetooth stack in future versions of android, so that we're not faced with generic errors which are impossible to debug.
Also, it would be great if you could provide documentation or links to the source code for the system 'Bluetooth app' such that we can understand what goes on inside this black box and work out why clearing the bluetooth cache is effective in these scenarios.