Make navController property lazy in NavHostFragment [220186282]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Feb 17, 2022 10:09PM

Once Fragments are driven by Lifecycle (https://issuetracker.google.com/127528777), the NavController will not yet be available an Activity's onCreate() function.

We should make the navController property in NavHostFragment lazy and make sure it is unconditionally created it in the NavHostFragment’s onCreate() or created early when called.

Comments

ap...@google.com <ap...@google.com> #2Mar 15, 2023 11:49PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

jb...@google.com <jb...@google.com> #3Mar 16, 2023 10:42PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

pr...@google.com <pr...@google.com> #4Mar 22, 2023 08:22PM

deleted

Issue 220186282

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 15, 2023 11:49PM

jb...@google.com <jb...@google.com> #3Mar 16, 2023 10:42PM

pr...@google.com <pr...@google.com> #4Mar 22, 2023 08:22PM

Add comment

Issue metadata