After switching from appcompat v1.3.1 to v1.4.1 we have noticed change in behavior for AppCompatEditText, specifically setting clickable=false from xml no longer have any effect.

Affected version: appcomapt v1.4.1

Steps to reproduce:

Create AppCompatEditText in xml
Set android:clickable="false"
Run the app and either check layout inspector or connect debugger to check isClickable()

Actual behavior:

AppCompatEditText is clickable even though clickable is set to false

Expect Behavior:

AppCompatEditText should respect clickable attribute set from xml.

Additional information:

After looking through the changes to appcompat library, looks like the issue been introduced in:

Add EmojiCompat to AppCompatEditText https://android.googlesource.com/platform/frameworks/support/+/ab8e5e277ffc64b639933b7669fb3945c7f130db

With this change we are now calling

super.setKeyListener(wrappedKeyListener);

from the constructor, which would call

android.widget.TextView#fixFocusableAndClickableSettings

Which in turn would make view clickable again:

private void fixFocusableAndClickableSettings() {
    if (mMovement != null || (mEditor != null && mEditor.mKeyListener != null)) {
        setFocusable(FOCUSABLE);
        setClickable(true);
        setLongClickable(true);
    } else {
        setFocusable(FOCUSABLE_AUTO);
        setClickable(false);
        setLongClickable(false);
    }
}

Issue 221094907

Mentioned issues (1)

Links (2)

Issue metadata