AppCompatEditText no longer respect clickable attribute set in xml [221094907]

Fixed

Bug

Status Update

No update yet.

Description

vo...@gmail.com

created issue #1

Feb 23, 2022 10:16PM

After switching from appcompat v1.3.1 to v1.4.1 we have noticed change in behavior for AppCompatEditText, specifically setting clickable=false from xml no longer have any effect.

Affected version: appcomapt v1.4.1

Steps to reproduce:

Create AppCompatEditText in xml
Set android:clickable="false"
Run the app and either check layout inspector or connect debugger to check isClickable()

Actual behavior:

AppCompatEditText is clickable even though clickable is set to false

Expect Behavior:

AppCompatEditText should respect clickable attribute set from xml.

Additional information:

After looking through the changes to appcompat library, looks like the issue been introduced in:

Add EmojiCompat to AppCompatEditText https://android.googlesource.com/platform/frameworks/support/+/ab8e5e277ffc64b639933b7669fb3945c7f130db

With this change we are now calling

super.setKeyListener(wrappedKeyListener);

from the constructor, which would call

android.widget.TextView#fixFocusableAndClickableSettings

Which in turn would make view clickable again:

private void fixFocusableAndClickableSettings() {
    if (mMovement != null || (mEditor != null && mEditor.mKeyListener != null)) {
        setFocusable(FOCUSABLE);
        setClickable(true);
        setLongClickable(true);
    } else {
        setFocusable(FOCUSABLE_AUTO);
        setClickable(false);
        setLongClickable(false);
    }
}

Comments

al...@google.com <al...@google.com> Feb 23, 2022 10:38PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #2Mar 3, 2022 11:01PM

Accepted by se...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit c46d3e79b2ea8b839358f0215b0a432ef8fad7a2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:23:25 2022

Convert androidx.activity.Cancellable to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Change-Id: I057f3e54811e7399e40083ef5e3915adc4fa425d

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288554

se...@google.com <se...@google.com> #3Mar 3, 2022 11:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7fd8a3206a49baefee8340f0839fcd4de7716788
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:13:23 2022

Rename androidx.activity.Cancellable from .java to .kt

Test: n/a
Bug:257291701
Change-Id: I7f2ff8ce79af41c6437fb9a0f1be90e8990495e8

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288553

vo...@gmail.com <vo...@gmail.com> #4Mar 4, 2022 12:33AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4d21e0a45f19ed238ef30756f576930af07449c2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:25:08 2022

Convert ActivityResultCallback to kotlin

Including clean up in test usages of this interface

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: Converted ActvitiyResultCallback to kotlin. Maintains source and binary comptability.
Change-Id: Ifc5e5e1a9a7ed4e281007830fb8d4c74237c63ce

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288334

ap...@google.com <ap...@google.com> #5Mar 4, 2022 07:13PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit ae5bcbc9174b9767f143bfd9629a69fcd3ed325d
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:06:36 2022

Rename ActivityResultCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I43a8c76cb51e3eee4a1ec2cb6f0128753d85965d

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288333

Issue 221094907