AppCompatEditText no longer respect clickable attribute set in xml [221094907]

Fixed

Bug

Status Update

No update yet.

Description

vo...@gmail.com

created issue #1

Feb 23, 2022 10:16PM

After switching from appcompat v1.3.1 to v1.4.1 we have noticed change in behavior for AppCompatEditText, specifically setting clickable=false from xml no longer have any effect.

Affected version: appcomapt v1.4.1

Steps to reproduce:

Create AppCompatEditText in xml
Set android:clickable="false"
Run the app and either check layout inspector or connect debugger to check isClickable()

Actual behavior:

AppCompatEditText is clickable even though clickable is set to false

Expect Behavior:

AppCompatEditText should respect clickable attribute set from xml.

Additional information:

After looking through the changes to appcompat library, looks like the issue been introduced in:

Add EmojiCompat to AppCompatEditText https://android.googlesource.com/platform/frameworks/support/+/ab8e5e277ffc64b639933b7669fb3945c7f130db

With this change we are now calling

super.setKeyListener(wrappedKeyListener);

from the constructor, which would call

android.widget.TextView#fixFocusableAndClickableSettings

Which in turn would make view clickable again:

private void fixFocusableAndClickableSettings() {
    if (mMovement != null || (mEditor != null && mEditor.mKeyListener != null)) {
        setFocusable(FOCUSABLE);
        setClickable(true);
        setLongClickable(true);
    } else {
        setFocusable(FOCUSABLE_AUTO);
        setClickable(false);
        setLongClickable(false);
    }
}

Comments

al...@google.com <al...@google.com> Feb 23, 2022 10:38PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #2Mar 3, 2022 11:01PM

Accepted by se...@google.com.

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

se...@google.com <se...@google.com> #3Mar 3, 2022 11:53PM

Great! Thanks a lot, I'll look for the live updates soon!

vo...@gmail.com <vo...@gmail.com> #4Mar 4, 2022 12:33AM

Thank you for a quick fix!

ap...@google.com <ap...@google.com> #5Mar 4, 2022 07:13PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 56a99dd94838976903e4e5b92987f6b0f9ca29ff
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Mar 03 15:44:47 2022

[bugfix] Appcompat EditText keeps xml clickable or longClickable

Changes
- AppCompatEditText
- AppCompatAutoCompleteEditText
- AppCompatMultiAutoCompleteEditText

All three classes will not reset `clickable` or `longClickable` in
constructor.

This reverts the behavior change introduced by emoji2 in appcompat
1.4.0.

Fixes:

b/221094907

Relnote: "AppCompatEditText, AppCompatAutoCompleteEditText,
AppCompatMultiAutoCompleteEditText will no longer reset clickable or
longClickable in the constructor when set in XML."
Test: ./gradlew :appcompat:appc:cAT

Change-Id: Ic5066da9059eab40e3c2bff7c16edc5037430c12

M appcompat/appcompat/src/androidTest/res/layout/appcompat_edittext_emoji_activity.xml
M appcompat/appcompat/src/androidTest/res/layout/appcompat_autocompletetextview_emoji_activity.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatMultiAutoCompleteTextView.java
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatAutoCompleteTextViewEmojiTest.java
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatEditTextEmojiTest.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatEditText.java
M appcompat/appcompat/src/androidTest/res/layout/appcompat_multiautocompletetextview_emoji_activity.xml
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatAutoCompleteTextView.java
M appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatMultiAutoCompleteTextViewEmojiTest.java

https://android-review.googlesource.com/2007911

Issue 221094907