Fixed
Status Update
Comments
da...@gmail.com <da...@gmail.com> #2
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
wu...@google.com <wu...@google.com> #3
Great! Thanks a lot, I'll look for the live updates soon!
ch...@google.com <ch...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 87d4e0db21b5f7ad8c31af4f6596105c77b1a31d
Author: Charcoal Chen <charcoalchen@google.com>
Date: Tue Mar 15 10:12:02 2022
Fix AbstractMethodError issue happened when apps use extensions and enable proguard
Force return false when the implementation classes do not exist instead of implementing default stub classes.
Relnote: "Fix AbstractMethodError issue happened when apps use extensions and enable proguard."
Bug: 222726805
Test: ./gradlew :camera:camera-camera2-pipe-integration:build && ./gradlew camera:camera-extensions:connectedAndroidTest && ./gradlew camera:integration-tests:camera-testapp-extensions:connectedAndroidTest && manual test
Change-Id: I7cbaf1aae571a2b4c12859171bcd46c529e33d57
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/ImageCaptureConfigProvider.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/BasicVendorExtender.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/PreviewConfigProvider.java
https://android-review.googlesource.com/2026243
Branch: androidx-main
commit 87d4e0db21b5f7ad8c31af4f6596105c77b1a31d
Author: Charcoal Chen <charcoalchen@google.com>
Date: Tue Mar 15 10:12:02 2022
Fix AbstractMethodError issue happened when apps use extensions and enable proguard
Force return false when the implementation classes do not exist instead of implementing default stub classes.
Relnote: "Fix AbstractMethodError issue happened when apps use extensions and enable proguard."
Bug: 222726805
Test: ./gradlew :camera:camera-camera2-pipe-integration:build && ./gradlew camera:camera-extensions:connectedAndroidTest && ./gradlew camera:integration-tests:camera-testapp-extensions:connectedAndroidTest && manual test
Change-Id: I7cbaf1aae571a2b4c12859171bcd46c529e33d57
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/ImageCaptureConfigProvider.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/BasicVendorExtender.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/PreviewConfigProvider.java
Description
CameraX version:
Traceback from inside CameraX from calling
ExtensionsManager.isExtensionAvailable
:Several of the impacted devices:
Tecno TECNO SPARK 7P Infinix HOT 10S Tecno POVA
Our app name on the Play Store is app.grapheneos.camera.play. You can also obtain a standalone variant of the app from GitHub:https://github.com/GrapheneOS/Camera/releases . It's open source so you can look at what we're doing in the source code, but it's not anything special beyond detecting the available CameraX extensions in the obvious way.