LinearProgressIndicator shape [222964817]

Fixed

Bug

Status Update

No update yet.

Description

sz...@gmail.com

created issue #1

Mar 6, 2022 07:38PM

Jetpack Compose release version: 1.1.1
Android Studio Build: Bumblebee Patch 2
Kotlin version: 1.6.20

Please make the shape of LinearProgressIndicator modifiable as well which shows the progress..
Currently only the "frame" is modifiable via the clip modifier.

Thank you!

Comments

so...@google.com <so...@google.com> Mar 10, 2022 06:52PM

Assigned to je...@google.com.

pa...@gmail.com <pa...@gmail.com> #2Aug 5, 2022 05:10AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

te...@gmail.com <te...@gmail.com> #3Sep 27, 2022 11:25PM

Along with these a great addition would be to open the stroke width for the background track as well. In the code the same width is passed to draw the LinearIndicator and the background for it. Strokewidth is obtained from the height. Only if these were separated, we could customize the progressIndicator to have the progress stroke greater than the background stroke width.

ma...@google.com <ma...@google.com> Nov 28, 2022 06:26PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> Nov 29, 2022 06:36PM

Accepted by ma...@google.com.

ma...@google.com <ma...@google.com> #4Dec 8, 2022 08:30PM

After consideration, we will be adding a parameter to configure the stroke cap of the indicators. Further shape customization or separate stroke widths for track/background are outside the scope of what we want to support in the library.

ap...@google.com <ap...@google.com> #5Dec 8, 2022 10:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit 013d7bbb021ed16b31afdcedf3936c467a8b3ed5
Author: Max Alfonso-Ying <maxying@google.com>
Date: Wed Nov 30 17:55:39 2022

Add track and stroke cap to progress indicators

Bug:

b/216325962

b/222964817

Test: added new screenshots
Relnote: "Added a track color parameter for circular
progress indicators, and a stroke cap parameter for both
circular and linear progress indicators."
Change-Id: Ie668cc47ce9ce3aa688ad3c3ed9e9e15fdbda5e9

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ProgressIndicator.kt
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ProgressIndicatorScreenshotTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ProgressIndicator.kt

https://android-review.googlesource.com/2322195

ap...@google.com <ap...@google.com> #6Dec 8, 2022 10:55PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit bfb61a63cca79430f547bc3ae08abb82dab8aee5
Author: Max Alfonso-Ying <maxying@google.com>
Date: Wed Nov 30 17:51:36 2022

Add new progress indicator screenshots.

Also renames old screenshots from "definite" -> "determinate".

Bug:

b/216325962

b/222964817

Change-Id: Ib41b5bce4db06b58612781befb5521f0bc9c7b8d

M compose/material3/material3/circularProgressIndicator_darkTheme_determinate_cuttlefish.png
A compose/material3/material3/circularProgressIndicator_lightTheme_determinate_customCapAndTrack_cuttlefish.png
M compose/material3/material3/circularProgressIndicator_lightTheme_determinate_cuttlefish.png
M compose/material3/material3/circularProgressIndicator_lightTheme_indeterminate_cuttlefish.png
M compose/material3/material3/linearProgressIndicator_darkTheme_determinate_cuttlefish.png
A compose/material3/material3/linearProgressIndicator_lightTheme_determinate_customCap_cuttlefish.png
M compose/material3/material3/linearProgressIndicator_lightTheme_determinate_cuttlefish.png
M compose/material3/material3/linearProgressIndicator_lightTheme_indeterminate_cuttlefish.png

https://android-review.googlesource.com/2320456

sz...@gmail.com <sz...@gmail.com> #7Dec 9, 2022 12:53AM

Thats great! Thanks Max

ma...@google.com <ma...@google.com> Dec 12, 2022 06:47PM

Marked as fixed.

na...@google.com <na...@google.com> #8Jan 11, 2023 08:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.4.0-alpha04
androidx.compose.material3:material3:1.1.0-alpha04