Fixed
Status Update
Comments
so...@google.com <so...@google.com>
pa...@gmail.com <pa...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit a330c0d3bcdd41326f37968a60e6084ad4a2e32c
Author: Chet Haase <chet@google.com>
Date: Wed Jul 05 07:26:46 2023
Convert APIs using PointF to use Float instead
PointF is a convenient mechanism for passing around x.y values
representing 2D points. But there are downsides, including:
- Converting to PointF: You may not have the data in PointF form
to begin with, so using an API which takes PointF requires converting
the data to that form (including allocating a PointF object every time)
- Mutability: Point structures can be mutated internally, causing
unpredictability in what that mutation means. Should the library
react to those changes? Ignore them? Do defensive copies (requiring
even more allocations)? Using primitive types like Float make the
behavior more obvious (by making the data inherently immutable).
- Allocations: Whenever we use object types, there are necessarily
allocations on the Java heap for them. This puts pressure on the GC
at both allocation and collection time. Given the amount of points
being passed around (especially at morph creation time, when curves
are being split and created), this causes a lot of PointF objects to
be allocated (even temporarily). Using Float avoids that problem.
Also fixed bug with unclosed paths causing discontinuity at the
start/end point.
Bug: 276466399
Bug: 290254314
Test: integration and unit tests pass
Relnote: PointF parameters changed to Float pairs
Change-Id: Id4705d27c7be31b26ade8186b99fffe2e2f8450e
M graphics/graphics-shapes/api/current.txt
M graphics/graphics-shapes/api/restricted_current.txt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicShapeTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonMeasureTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/TestUtils.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Cubic.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FeatureMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FloatMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Morph.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/PolygonMeasure.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Utils.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/DebugDraw.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MaterialShapes.kt
https://android-review.googlesource.com/2649119
Branch: androidx-main
commit a330c0d3bcdd41326f37968a60e6084ad4a2e32c
Author: Chet Haase <chet@google.com>
Date: Wed Jul 05 07:26:46 2023
Convert APIs using PointF to use Float instead
PointF is a convenient mechanism for passing around x.y values
representing 2D points. But there are downsides, including:
- Converting to PointF: You may not have the data in PointF form
to begin with, so using an API which takes PointF requires converting
the data to that form (including allocating a PointF object every time)
- Mutability: Point structures can be mutated internally, causing
unpredictability in what that mutation means. Should the library
react to those changes? Ignore them? Do defensive copies (requiring
even more allocations)? Using primitive types like Float make the
behavior more obvious (by making the data inherently immutable).
- Allocations: Whenever we use object types, there are necessarily
allocations on the Java heap for them. This puts pressure on the GC
at both allocation and collection time. Given the amount of points
being passed around (especially at morph creation time, when curves
are being split and created), this causes a lot of PointF objects to
be allocated (even temporarily). Using Float avoids that problem.
Also fixed bug with unclosed paths causing discontinuity at the
start/end point.
Bug: 276466399
Bug: 290254314
Test: integration and unit tests pass
Relnote: PointF parameters changed to Float pairs
Change-Id: Id4705d27c7be31b26ade8186b99fffe2e2f8450e
M graphics/graphics-shapes/api/current.txt
M graphics/graphics-shapes/api/restricted_current.txt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicShapeTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonMeasureTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/TestUtils.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Cubic.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FeatureMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FloatMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Morph.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/PolygonMeasure.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Utils.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/DebugDraw.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MaterialShapes.kt
te...@gmail.com <te...@gmail.com> #3
PointF was the main (possibly only) mutability issue, marking this as fixed
ma...@google.com <ma...@google.com>
ma...@google.com <ma...@google.com>
ma...@google.com <ma...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.graphics:graphics-shapes:1.0.0-alpha04
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 013d7bbb021ed16b31afdcedf3936c467a8b3ed5
Author: Max Alfonso-Ying <maxying@google.com>
Date: Wed Nov 30 17:55:39 2022
Add track and stroke cap to progress indicators
Bug: b/216325962 , b/222964817
Test: added new screenshots
Relnote: "Added a track color parameter for circular
progress indicators, and a stroke cap parameter for both
circular and linear progress indicators."
Change-Id: Ie668cc47ce9ce3aa688ad3c3ed9e9e15fdbda5e9
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ProgressIndicator.kt
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ProgressIndicatorScreenshotTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ProgressIndicator.kt
https://android-review.googlesource.com/2322195
Branch: androidx-main
commit 013d7bbb021ed16b31afdcedf3936c467a8b3ed5
Author: Max Alfonso-Ying <maxying@google.com>
Date: Wed Nov 30 17:55:39 2022
Add track and stroke cap to progress indicators
Bug:
Test: added new screenshots
Relnote: "Added a track color parameter for circular
progress indicators, and a stroke cap parameter for both
circular and linear progress indicators."
Change-Id: Ie668cc47ce9ce3aa688ad3c3ed9e9e15fdbda5e9
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ProgressIndicator.kt
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ProgressIndicatorScreenshotTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ProgressIndicator.kt
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support-golden
Branch: androidx-main
commit bfb61a63cca79430f547bc3ae08abb82dab8aee5
Author: Max Alfonso-Ying <maxying@google.com>
Date: Wed Nov 30 17:51:36 2022
Add new progress indicator screenshots.
Also renames old screenshots from "definite" -> "determinate".
Bug: b/216325962 , b/222964817
Change-Id: Ib41b5bce4db06b58612781befb5521f0bc9c7b8d
M compose/material3/material3/circularProgressIndicator_darkTheme_determinate_cuttlefish.png
A compose/material3/material3/circularProgressIndicator_lightTheme_determinate_customCapAndTrack_cuttlefish.png
M compose/material3/material3/circularProgressIndicator_lightTheme_determinate_cuttlefish.png
M compose/material3/material3/circularProgressIndicator_lightTheme_indeterminate_cuttlefish.png
M compose/material3/material3/linearProgressIndicator_darkTheme_determinate_cuttlefish.png
A compose/material3/material3/linearProgressIndicator_lightTheme_determinate_customCap_cuttlefish.png
M compose/material3/material3/linearProgressIndicator_lightTheme_determinate_cuttlefish.png
M compose/material3/material3/linearProgressIndicator_lightTheme_indeterminate_cuttlefish.png
https://android-review.googlesource.com/2320456
Branch: androidx-main
commit bfb61a63cca79430f547bc3ae08abb82dab8aee5
Author: Max Alfonso-Ying <maxying@google.com>
Date: Wed Nov 30 17:51:36 2022
Add new progress indicator screenshots.
Also renames old screenshots from "definite" -> "determinate".
Bug:
Change-Id: Ib41b5bce4db06b58612781befb5521f0bc9c7b8d
M compose/material3/material3/circularProgressIndicator_darkTheme_determinate_cuttlefish.png
A compose/material3/material3/circularProgressIndicator_lightTheme_determinate_customCapAndTrack_cuttlefish.png
M compose/material3/material3/circularProgressIndicator_lightTheme_determinate_cuttlefish.png
M compose/material3/material3/circularProgressIndicator_lightTheme_indeterminate_cuttlefish.png
M compose/material3/material3/linearProgressIndicator_darkTheme_determinate_cuttlefish.png
A compose/material3/material3/linearProgressIndicator_lightTheme_determinate_customCap_cuttlefish.png
M compose/material3/material3/linearProgressIndicator_lightTheme_determinate_cuttlefish.png
M compose/material3/material3/linearProgressIndicator_lightTheme_indeterminate_cuttlefish.png
sz...@gmail.com <sz...@gmail.com> #7
Thats great! Thanks Max
ma...@google.com <ma...@google.com>
na...@google.com <na...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.4.0-alpha04
androidx.compose.material3:material3:1.1.0-alpha04
Description
Android Studio Build: Bumblebee Patch 2
Kotlin version: 1.6.20
Please make the shape of LinearProgressIndicator modifiable as well which shows the progress..
Currently only the "frame" is modifiable via the clip modifier.
Thank you!