[FR] Baseline profiles - adb command with selected device [223359380]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Mar 8, 2022 01:45PM

Version used: 1.1.0-beta04

After profile is generated it prints the command to pull the profile from the device. Can we add device serial to the command?

Developers will most likely have 2 android devices attached

userdebug emulator -- to generate the profile
user physical phone -- to verify the profile

Can we specify the serial to the command?

To copy the profile use: adb -s emulator-5554 pull "/storage/emulated/0/Android/media/com.google.samples.apps.sunflower.macrobenchmark/BaselineProfileGenerator_startup-baseline-prof-2022-03-08-13-37-55.txt" .

Maybe it's a XY problem, but if it's easy, would be nice.

Comments

ra...@google.com <ra...@google.com> #2Mar 8, 2022 05:34PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

cc...@google.com <cc...@google.com> Oct 21, 2022 10:09PM

Reassigned to cc...@google.com.

ap...@google.com <ap...@google.com> #3Oct 24, 2022 05:26PM

Marked as fixed.

yea i'll take it.

na...@google.com <na...@google.com> #4Nov 9, 2022 06:28PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

Issue 223359380

Description

Issue summary

Comments

ra...@google.com <ra...@google.com> #2Mar 8, 2022 05:34PM

cc...@google.com <cc...@google.com> Oct 21, 2022 10:09PM

ap...@google.com <ap...@google.com> #3Oct 24, 2022 05:26PM

na...@google.com <na...@google.com> #4Nov 9, 2022 06:28PM

Add comment

Issue metadata