AnimatedVisibility doesn't work with FloatingActionButton in Scaffold [224005027]

Assigned

Bug

Status Update

No update yet.

Description

ph...@gmail.com

created issue #1

Mar 13, 2022 06:36AM

Jetpack Compose release version: 1.1.1 & 1.2.0-alpha04

With some animation types, including AnimatedVisibility default ones, the view doesn't appear at all.

var flag by remember { mutableStateOf(true) }
Scaffold(
    floatingActionButton = {
        AnimatedVisibility(visible = flag)
        {
            FloatingActionButton({}) {
                Icon(Icons.Default.ArrowBack, null)
            }
        }
    },
) {
    Switch(flag, { flag = it })
}

ScaleIn/out works fine.

If I put AnimatedVisibility in a Box(Modifier.size(FabSize)), it works almost fine, expect the shadow - it's being clipped during animation until the final frame.

withBox.gif

86 KB

View

Download

withoutBox.gif

101 KB

View

Download

Comments

ca...@gmail.com <ca...@gmail.com> #2Mar 14, 2022 06:16AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

so...@google.com <so...@google.com> Mar 14, 2022 10:19AM

Assigned to je...@google.com.

ph...@gmail.com <ph...@gmail.com> #3Mar 14, 2022 12:58PM

expandIn { IntSize ... fix works, but has the same problem as with wrapping AnimatedVisibility in fixed size Box: the shadow is cropped during the transition, as can be seen in the withBox.gif attached to original post.

ap...@google.com <ap...@google.com> #4Jun 29, 2022 04:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3658fbf9f31f7efe35ecc726fe6cbffbd07b4373
Author: Cagdas Caglak <cagdascaglak@gmail.com>
Date: Mon Apr 04 10:01:41 2022

Fix AnimatedVisibility issue with FloatingActionButton in Scaffold

With scaffold change which I mentioned below, it breaks the fab button has 0 size. androidx.compose.animation.TransitionData has ChangeSize data and if enter animation has (0, 0) initialSize(it's default at animations), affected change is eliminating zero size fab component when recomposition runs.

Bug: 224005027
Relnote: "Fix AnimatedVisibility issue with FloatingActionButton in Scaffold"
Affected ChangeId: I4e80378133be73fdb1700daf7a1bc926504a7611
Test: Run "androidx.compose.material.ScaffoldTest#scaffold_geometry_animated_fabSize" test

Change-Id: I3a0aec281af02a829375aeb2ca4474cbf1eb05a5

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Scaffold.kt

https://android-review.googlesource.com/2052969

sg...@google.com <sg...@google.com> #5Jun 29, 2022 04:40PM

Marked as fixed.

Cagdas fix was submitted at https://r.android.com/2052969

ja...@gmail.com <ja...@gmail.com> #6Nov 10, 2022 12:35PM

Still broken. Version 1.3.1

Message last modified on Nov 10, 2022 12:36PM

broken.jpeg

6 KB

View

Download

start.jpg

6.1 KB

View

Download

sh...@gmail.com <sh...@gmail.com> #7Jan 22, 2023 09:20AM

The same issue happens for me with androidx.compose.material3:material3:1.1.0-alpha04, button doesn't appear with default animations for AnimatedVisibility, but it works when using scaleIn/scaleOut animations instead

pa...@gmail.com <pa...@gmail.com> #8May 1, 2023 04:43PM

I'm still having this issue with androidx.compose.material3:material3:1.1.0-beta02. Default animations don't work at all, i.e. nothing gets shown. Fade animations get clipped. Scale animations seem to work fine.

Message last modified on May 1, 2023 04:46PM

jo...@asos.com <jo...@asos.com> #9Aug 25, 2023 01:43PM

Still an issue in "androidx.compose:compose-bom:2023.08.00". Affects anything with an elevation set in floatingActionButton when using a scaffold & AnimateVisibility.

Message last modified on Aug 29, 2023 10:27AM

co...@google.com <co...@google.com> Aug 25, 2023 06:22PM

Status: Assigned (reopened)

pe...@gmail.com <pe...@gmail.com> #10Sep 8, 2023 10:23PM

I am still facing the same issue with androidx.compose.material3:material3:1.1.1. It happens mainly if the FloatingActionButton is set from visible=false to visible=true inside a AnimatedVisibility

Message last modified on Sep 8, 2023 10:27PM

te...@gmail.com <te...@gmail.com> #11Sep 24, 2023 01:20PM

still not working...

mi...@gmail.com <mi...@gmail.com> #12Jan 1, 2024 04:20PM

This issue is still occurring in androidx.compose:compose-bom:2023.10.01

an...@gmail.com <an...@gmail.com> #13Jan 8, 2024 09:42PM

I am also experiencing this issue in 2023.10.01.

As mentioned in the original issue, setting enter = scaleIn() and exit = scaleOut() on the AnimatedVisibility seems to fix the issue, but does not work as a solution when there is more than one FAB (primary extended and secondary small FAB).

Message last modified on Jan 8, 2024 09:43PM

ph...@bayf.net <ph...@bayf.net> #14Mar 22, 2024 08:04PM

Still happening with 2024.03.00

ja...@billease.com <ja...@billease.com> #15Apr 4, 2024 07:36AM

Still happening in 2024.04.00

mi...@gmail.com <mi...@gmail.com> #16Jul 6, 2024 02:15PM

Still reproducing 06/07/2024.

mc...@solem.fr <mc...@solem.fr> #17Aug 20, 2024 02:52PM

Still reproducing as today.

Animation androidx.compose.animation:animation:1.7.0-beta06

Foundation androidx.compose.foundation:foundation:1.7.0-beta06

pa...@outlook.com <pa...@outlook.com> #18Jan 5, 2025 05:45AM

2025 and still happening

Issue 224005027

Description

Issue summary

Comments

ca...@gmail.com <ca...@gmail.com> #2Mar 14, 2022 06:16AM

so...@google.com <so...@google.com> Mar 14, 2022 10:19AM

ph...@gmail.com <ph...@gmail.com> #3Mar 14, 2022 12:58PM

ap...@google.com <ap...@google.com> #4Jun 29, 2022 04:39PM

sg...@google.com <sg...@google.com> #5Jun 29, 2022 04:40PM

ja...@gmail.com <ja...@gmail.com> #6Nov 10, 2022 12:35PM

sh...@gmail.com <sh...@gmail.com> #7Jan 22, 2023 09:20AM

pa...@gmail.com <pa...@gmail.com> #8May 1, 2023 04:43PM

jo...@asos.com <jo...@asos.com> #9Aug 25, 2023 01:43PM

co...@google.com <co...@google.com> Aug 25, 2023 06:22PM

pe...@gmail.com <pe...@gmail.com> #10Sep 8, 2023 10:23PM

te...@gmail.com <te...@gmail.com> #11Sep 24, 2023 01:20PM

mi...@gmail.com <mi...@gmail.com> #12Jan 1, 2024 04:20PM

an...@gmail.com <an...@gmail.com> #13Jan 8, 2024 09:42PM

ph...@bayf.net <ph...@bayf.net> #14Mar 22, 2024 08:04PM

ja...@billease.com <ja...@billease.com> #15Apr 4, 2024 07:36AM

mi...@gmail.com <mi...@gmail.com> #16Jul 6, 2024 02:15PM

mc...@solem.fr <mc...@solem.fr> #17Aug 20, 2024 02:52PM

pa...@outlook.com <pa...@outlook.com> #18Jan 5, 2025 05:45AM

Add comment

Issue metadata