Invert performMouseInput { scroll(2f) } [224992993]

Fixed

Bug

Status Update

No update yet.

Description

ig...@jetbrains.com

created issue #1

Mar 16, 2022 07:38PM

Jetpack Compose version: 3621f0a7 Jetpack Compose component used: performMouseInput, scroll

In https://android-review.googlesource.com/c/platform/frameworks/support/+/1913489 we inverted vertical mouse scroll, because on Android when we scroll down (the top touch point of the wheel moves to the user), scrollX is positive, but it should be negative.

In tests when we make artificial scroll event, we should invert x axis too (to avoid confusion).

See for example the test: https://android-review.googlesource.com/c/platform/frameworks/support/+/1994356/3/compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/OnPointerEventTest.kt#155

Now it is:

rule.onNodeWithTag(tag).performMouseInput {
    scroll(2f)
}
assertThat(events.last().changes.first().scrollDelta).isEqualTo(Offset(0f, -2f))

But it should be:

rule.onNodeWithTag(tag).performMouseInput {
    scroll(2f)
}
assertThat(events.last().changes.first().scrollDelta).isEqualTo(Offset(0f, 2f))

Comments

ig...@jetbrains.com <ig...@jetbrains.com> #2Mar 16, 2022 07:40PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

je...@google.com <je...@google.com> #3Apr 22, 2022 10:36AM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

ig...@jetbrains.com <ig...@jetbrains.com> #4Apr 22, 2022 02:06PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

Message last modified on Apr 22, 2022 02:07PM

ig...@jetbrains.com <ig...@jetbrains.com> #5Apr 22, 2022 02:14PM

deleted

Message last modified on Apr 22, 2022 02:24PM

je...@google.com <je...@google.com> #6Apr 22, 2022 04:55PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

ap...@google.com <ap...@google.com> #7Apr 28, 2022 07:12PM

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

je...@google.com <je...@google.com> Apr 4, 2024 06:18PM

Marked as fixed.