Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7e6547f4bb57fbb488cdef23d743f731c6fd0cf7
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 23 16:21:31 2022
Remove visibleEntries experimental annotation
Lets make visibleEntries an actual stable API.
RelNote: "`visibleEntries` is no longer experimental."
Test: ./gradlew checkApi
Bug: 225394514
Change-Id: I4829fb8402901ea9e7ef31262f4b1c7ac3e26818
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
D navigation/navigation-runtime/src/main/java/androidx/navigation/NavControllerVisibleEntries.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
https://android-review.googlesource.com/2039225
Branch: androidx-main
commit 7e6547f4bb57fbb488cdef23d743f731c6fd0cf7
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 23 16:21:31 2022
Remove visibleEntries experimental annotation
Lets make visibleEntries an actual stable API.
RelNote: "`visibleEntries` is no longer experimental."
Test: ./gradlew checkApi
Bug: 225394514
Change-Id: I4829fb8402901ea9e7ef31262f4b1c7ac3e26818
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
D navigation/navigation-runtime/src/main/java/androidx/navigation/NavControllerVisibleEntries.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 4e8c0ba4829f25f2aab3daa89b6b7f8feaf1eb25
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 23 16:09:20 2022
Base visible entries off max lifecycle
Instead of having visible entries based off of the entry current
lifecycle which considers the host lifecycle, we should base them on the
maxLifecycle.
This means in the case of nested NavHost, the visible entries of the
inner NavHost will remain the same even if the outer state goes below
STARTED.
RelNote: "The `visibleEntries` `StateFlow provided by `NavController` is now based on the entry max Lifecycle state instead of the current Lifecycle state. This means that even if the host lifecycle of the navController goes below STARTED, the list of visible entires will remain the same."
Test: added test
Bug: 225394514
Change-Id: I9e2a810f261e9dc1e61417b168427b3bf597fbd5
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavBackStackEntryLifecycleTest.kt
https://android-review.googlesource.com/2039224
Branch: androidx-main
commit 4e8c0ba4829f25f2aab3daa89b6b7f8feaf1eb25
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 23 16:09:20 2022
Base visible entries off max lifecycle
Instead of having visible entries based off of the entry current
lifecycle which considers the host lifecycle, we should base them on the
maxLifecycle.
This means in the case of nested NavHost, the visible entries of the
inner NavHost will remain the same even if the outer state goes below
STARTED.
RelNote: "The `visibleEntries` `StateFlow provided by `NavController` is now based on the entry max Lifecycle state instead of the current Lifecycle state. This means that even if the host lifecycle of the navController goes below STARTED, the list of visible entires will remain the same."
Test: added test
Bug: 225394514
Change-Id: I9e2a810f261e9dc1e61417b168427b3bf597fbd5
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavBackStackEntryLifecycleTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 1cb5a423aa271f78c7b8c843f49e51f976909c1d
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 23 17:18:06 2022
Use visibleEntries in NavHost
Instead of all the custom code we currently use in NavHost to determine
which destinations to compose, we can just use visibleEntries directly
which has already sorted those destinations for us.
Moved the custom APIs over to DialogHost to fix that separately as the
DialogHost does not have access to a NavController.
RelNote: "NavHost now depend on `visibleEntries` from the NavController
to determine which entries to compose. This means that when using nested
NavHost the inner NavHost should now properly animate out."
Test: all existing tests pass
Bug: 225394514
Change-Id: I4ba2b542821154a76566f9c02cf7a95599a30f14
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/DialogHost.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
https://android-review.googlesource.com/2039231
Branch: androidx-main
commit 1cb5a423aa271f78c7b8c843f49e51f976909c1d
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 23 17:18:06 2022
Use visibleEntries in NavHost
Instead of all the custom code we currently use in NavHost to determine
which destinations to compose, we can just use visibleEntries directly
which has already sorted those destinations for us.
Moved the custom APIs over to DialogHost to fix that separately as the
DialogHost does not have access to a NavController.
RelNote: "NavHost now depend on `visibleEntries` from the NavController
to determine which entries to compose. This means that when using nested
NavHost the inner NavHost should now properly animate out."
Test: all existing tests pass
Bug: 225394514
Change-Id: I4ba2b542821154a76566f9c02cf7a95599a30f14
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/DialogHost.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
jb...@google.com
This has been fixed internally and will be available in the Navigation 2.5.0-alpha05 release.
Description
The visibleEntries stateFlow that is currently offered as an experimental API on NavController is populated based on the current lifecycle state of the entry. This means that it considers the hostLifecycleState of the entry when determining whether entries should be part of the list.
Because of this, when the navController is first created, depending on the lifecycle state when you call setGraph, it is possible for the visibleEntries to be empty until after the first navigate call. Also, if the hostLifecycle state is forced down, as in the case of using nested NavHost with different NavControllers in navigation-compose, entries are immediately removed from the list of visible entries although they might still be visible because of animations.
We should visible visible entries so that is always contains any entry that actually should be considered visible.