Fixed
Status Update
Comments
si...@google.com <si...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
[Deleted User] <[Deleted User]> #3
va...@gmail.com <va...@gmail.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
kl...@google.com <kl...@google.com>
al...@gmail.com <al...@gmail.com> #5
I am able to reproduce this issue as well in the latest 1.2.0-alpha08
compose version.
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 1ab8d62de323dff347c29ccdaf42c551ede4aa8c
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Apr 27 17:44:11 2022
Fix focused text fields not hiding the keyboard when removed from composition.
The root cause of this issue is actually a regression in how focus
events are delivered, tracked as b/230536793 . That fix is a lot more
complicated, so I will address in a follow-up.
Fixes: b/225541817
Test: ./gradlew :compose:f:f:cDAT
Relnote: "Fixed regression where text fields would not hide the keyboard
when removed from the composition while focused."
Change-Id: I7a41031f5fb257200cf9958fe0d2a64af2519c9a
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldInputServiceIntegrationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
https://android-review.googlesource.com/2078818
Branch: androidx-main
commit 1ab8d62de323dff347c29ccdaf42c551ede4aa8c
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Apr 27 17:44:11 2022
Fix focused text fields not hiding the keyboard when removed from composition.
The root cause of this issue is actually a regression in how focus
events are delivered, tracked as
complicated, so I will address in a follow-up.
Fixes:
Test: ./gradlew :compose:f:f:cDAT
Relnote: "Fixed regression where text fields would not hide the keyboard
when removed from the composition while focused."
Change-Id: I7a41031f5fb257200cf9958fe0d2a64af2519c9a
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldInputServiceIntegrationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
da...@gmail.com <da...@gmail.com> #7
The issue persists in 1.2.0-rc02 when TextField
is in disabled state.
ki...@gmail.com <ki...@gmail.com> #8
This issue still persists... is there a fix already? Is it fixed in 1.3(.x)? Or planned for 1.4 at last?
eo...@gmail.com <eo...@gmail.com> #9
is this issue fixed? I think it sill persists
ha...@google.com <ha...@google.com> #10
Can you please share a minimum repro project? This is important for us to understand your full dependency setup.
il...@gmail.com <il...@gmail.com> #11
We are also encountering this issue, which started after migrating our app to Compose Navigation (version 2.8.3). Specifically, when a user logs in by entering their credentials and pressing the "Sign In" button, the keyboard closes as expected. However, this action triggers navigation, and upon transitioning to the next screen—a screen using a LazyColumn without any input fields—the keyboard unexpectedly reopens.
Description
I use Kotlin 1.6.10 and the following compose libraries:
androidx.compose.ui:ui:1.1.1
androidx.compose.material:material:1.1.1
androidx.activity:activity-compose:1.4.0
androidx.navigation:navigation-compose:2.4.1
It is also reproducible with Compose 1.2.0-alpha05