Status Update
Comments
di...@google.com <di...@google.com>
je...@google.com <je...@google.com>
ga...@google.com <ga...@google.com> #2
Branch: main
commit 39f08f72219210c78d964f356552efd6c8a3275a
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Jan 19 14:12:31 2023
[Metadata] Update kotlin-metadata-jvm to version 0.6.0
Bug:
Change-Id: I2441b7c328acda8efa13c4e0a7c334cf275f0b44
M build.gradle
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassLevelInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassMetadataReader.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFileFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataRewriter.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassPartInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/test/java/com/android/tools/r8/kotlin/coroutines/KotlinxCoroutinesTestRunner.java
M src/test/java/com/android/tools/r8/kotlin/metadata/KotlinMetadataTestBase.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteBoxedTypesTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlineClassTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlinePropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteKeepTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteLocalDelegatedPropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewritePassThroughTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteRawTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteUnitPrimitiveTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteValueClassTest.java
ni...@nrbtech.io <ni...@nrbtech.io> #3
Branch: main
commit dde8cf4cd2e452225400d77819767cd48406cd41
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Jan 23 17:32:03 2023
[Metadata] Update service import in sanity check test
Bug:
Change-Id: I25d5a272b8a3cab18e638e85553bbf5b98997b60
M src/test/java/com/android/tools/r8/SanityCheck.java
bi...@google.com <bi...@google.com> #4
The public work of this has now been completed. I created
ni...@nrbtech.io <ni...@nrbtech.io> #5
Branch: 8.0
commit 177f2a32494e4e9baedd895eb920bc41825ef77b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:22:14 2023
Version 8.0.27
Bug:
Bug:
Bug:
Change-Id: Iebc28bdd06d6330116a8b12336f25be201603745
M src/main/java/com/android/tools/r8/Version.java
bi...@google.com <bi...@google.com> #6
Branch: 8.0
commit 1c9ab7b7cff3bdc3de67ce8b6cd032907f72c8ef
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:21:40 2023
[Metadata] Update service import in sanity check test
Bug:
Change-Id: I25d5a272b8a3cab18e638e85553bbf5b98997b60
M src/test/java/com/android/tools/r8/SanityCheck.java
ni...@nrbtech.io <ni...@nrbtech.io> #7
Branch: 8.0
commit 1db3d77589ae2bc16ba2501f9848d40afb780139
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:21:27 2023
Reland "[Metadata] Update kotlin-metadata-jvm to version 0.6.0"
This reverts commit 87b372dde22f9052f9fb86770921bdf6cb008ba6.
Change-Id: I7b361c05a686fbfffd399f5a7ee10f65c8513b2f
Bug:
M build.gradle
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassLevelInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassMetadataReader.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFileFacadeInfo.java
A src/main/java/com/android/tools/r8/kotlin/KotlinMetadataAnnotationWrapper.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataRewriter.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassPartInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/test/java/com/android/tools/r8/kotlin/coroutines/KotlinxCoroutinesTestRunner.java
M src/test/java/com/android/tools/r8/kotlin/metadata/KotlinMetadataTestBase.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteBoxedTypesTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlineClassTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlinePropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteKeepTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteLocalDelegatedPropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewritePassThroughTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteRawTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteUnitPrimitiveTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteValueClassTest.java
ww...@gmail.com <ww...@gmail.com> #8
Branch: main
commit 4ff176f892492b8bbb1a647f83cc0a9e679b40d9
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Jan 26 09:58:05 2023
[Metadata] Move away from deprecated metadata visitors
Bug:
Change-Id: I3cd8f4b0a78ef6bfe9d9c38e2629b89315d0c9d1
D src/main/java/com/android/tools/r8/kotlin/KmVisitorProviders.java
M src/main/java/com/android/tools/r8/kotlin/KotlinAnnotationInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinConstructorInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinContractInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinDeclarationContainerInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinEffectExpressionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinEffectInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFlexibleTypeUpperBoundInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFunctionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinJvmMethodSignatureInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinLambdaInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinLocalDelegatedPropertyInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinPackageInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinPropertyInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeAliasInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeParameterInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeProjectionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinValueParameterInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinVersionRequirementInfo.java
ww...@gmail.com <ww...@gmail.com> #9
After further investigation by removing parts of my gradle files line-by-line I found that crash happens when CMake is present in the includeBuild
library.
externalNativeBuild {
cmake {
path = file("CMakeLists.txt") // comment this line and AnalyticsService crash disappears
}
}
I've created minimal sample application to reproduce this problem.
bi...@google.com <bi...@google.com> #10
Thanks for sharing the project! It would be really helpful for us to reproduce the issue. Just to confirm, the error appears with "Android Studio Chipmunk | 2021.2.1 Patch 1" right?
ww...@gmail.com <ww...@gmail.com> #11
Yes, It happens on 2021.2.1 Patch 1. Didn't try other versions.
bi...@google.com <bi...@google.com>
ni...@nrbtech.io <ni...@nrbtech.io> #12
Nice work narrowing it down - I can also confirm I use CMake in an includeBuild library
[Deleted User] <[Deleted User]> #13
ro...@miquido.com <ro...@miquido.com> #14
ww...@gmail.com <ww...@gmail.com> #15
So far only workarouund I found is to use AGP 7.1 and AS Bamblebee. Otherwise it either crashes during sync or doesn't allow to debug C++ code :(
bi...@google.com <bi...@google.com> #16
One workaround is to disable analytics. You can go to ~/.android/analytics.settings
and change the hasOptedIn
value from true to false.
ww...@gmail.com <ww...@gmail.com> #17
Disabling analitics is fine for local machine but is really a chore when you have huge team and multiple build servers. Can it be done locally in the project so it can be pushed to git for example? Maybe in gradle.properties
or something similar?
bi...@google.com <bi...@google.com> #18
I am afraid it cannot be done in project like in gradle.properties
bi...@google.com <bi...@google.com> #19
Actually, can you try adding com.android.tools.analytics.AnalyticsSettings.setOptedIn(false)
to the build.gradle
file of each root project?
In your sample project, add it to MyLibrary/build.gradle
and MyApplication/build.gradle
ww...@gmail.com <ww...@gmail.com> #20
I couldn't add exact code you've provided bacause of the error Unresolved reference: setOptedIn
.
Intrestingly enough I could set opt in flag via reflections:
Class.forName("com.android.tools.analytics.AnalyticsSettings")
.getMethod("setOptedIn", Boolean::class.java)
.invoke(null , false)
It somewhat works but first sync always fails with the original error Could not create an instance of type com.android.build.gradle.internal.profile.AnalyticsService
.
Don't know how it will behaive with CI. Will check somewhere later, don't have access to CI at the moment.
ww...@gmail.com <ww...@gmail.com> #21
I don't know if these are really related but even though you can sync project from the second try - native code breakpoints don't work even with Dual
debug type. Moreover LLDB doesn't even attach on its own when debug type is Detect Automatically
.
It was not a problem with 7.1.X and Bumblebee.
bi...@google.com <bi...@google.com> #22
That is weird cause I am able to make it work by adding it to your sample project.
bi...@google.com <bi...@google.com> #23
Fixed with I905dd70a2e7ccf05b3a7da1c83e2af4260b71ece and the fix will be available since 8.0-alpha01.
ka...@gmail.com <ka...@gmail.com> #24
While I am building I receive:
"A build operation failed.
Failed to create service 'com.android.build.gradle.internal.profile.AnalyticsService_704aac9b-2502-42f4-80cd-cccdba9bb437'.
Failed to create service 'com.android.build.gradle.internal.profile.AnalyticsService_704aac9b-2502-42f4-80cd-cccdba9bb437'.
Could not create an instance of type com.android.build.gradle.internal.profile.AnalyticsService.
Cannot query the value of this property because it has no value available."
Details:
Android Studio version: Android Studio Electric Eel | 2022.1.1
OS: Windows 10
Java versions: Oracle OpenJDK 11.0.10, Azul Zulu version 13.0.10
And some more details below:
I would like to mention that my Android Studio project contains two projects on the same root as it is mentioned in the previous comments (multi-root project).
Here are some more tests I did:
Windows 10, Android Studio Electric Eel | 2022.1.1, Gradle 7.5, AGP 7.4.0 => The problem as it is described above
Windows 10, Android Studio Electric Eel | 2022.1.1, Gradle 7.5, AGP 7.3.1 => Build and run successfully
Windows 10, Android Studio Electric Eel | 2022.1.1, Gradle 7.4, AGP 7.3.1 => Build and run successfully
Mac OS Monterey 12.6.2, Android Studio Electric Eel | 2022.1.1, Gradle 7.5, AGP 7.4.0 => The problem as it is described above
Mac OS Monterey 12.6.2, Android Studio Electric Eel | 2022.1.1, Gradle 7.5, AGP 7.3.1 => Build and run successfully
Mac OS Monterey 12.6.2, Android Studio Dolphin | 2021.3.1, Gradle 7.5, AGP 7.4.0 => The problem as it is described above
Mac OS Monterey 12.6.2, Android Studio Dolphin | 2021.3.1, Gradle 7.5, AGP 7.3.1 => Could not run due to the reason that AGP 7.3.1 requires as minimum the Gradle 7.4
As I can understand, the problem is on the AGP 7.4.0 which tries to create the AnalyticsSettings instance.
As a current solution to my problem, I am using Gradle 7.5 with AGP 7.3.1 in the latest Android Studio versions(Dolphin and Electric) for my project.
Regards,
ga...@linecorp.com <ga...@linecorp.com> #25
Fixed with I905dd70a2e7ccf05b3a7da1c83e2af4260b71ece and the fix will be available since 8.0-alpha01.
Is it possible to backport this change on stable version(AGP 7.4)?
pa...@gmail.com <pa...@gmail.com> #26
@ww... in #20
> I couldn't add exact code you've provided because of the error Unresolved reference: setOptedIn.
This happens when the class is not on the right classpath.
It's housed in com.android.tools.analytics-library:shared:30.4.0.
Which is a transitive dependency of com.android.tools:sdk-common:30.4.0.
In one of the AGP 7.x versions a lot of dependencies (including sdk-common) have been moved from compile to runtime scope in the POM, so they moved from compileClasspath to runtimeClasspath configuration in Gradle.
So, in Kotlin we need the class be present and compileClasspath, Groovy doesn't care as it's interpreted and does exactly the reflective code you posted.
I couldn't make it work with this hack, tried many-many ways, but only synced by editing analytics.settings.
dm...@mapbox.com <dm...@mapbox.com> #27
The only workaround that worked was to disable `Send usage statistics to google` in settings, changing flag manually in `~./android/analytics.settings` had no effect and AS kept overwriting the file.
pa...@gmail.com <pa...@gmail.com> #28
Edit the file and make it read-only. It will warn on every AGP build, and on AS startup you'll get a weird opt-in dialog, but AS won't be able to change it back.
fu...@gmail.com <fu...@gmail.com> #29
Fixed with I905dd70a2e7ccf05b3a7da1c83e2af4260b71ece and the fix will be available since 8.0-alpha01.
Is it possible to backport this change on stable version(AGP 7.4) or gradle(7.5+)?
bi...@google.com <bi...@google.com> #30
Unfortunately, it is not an option
da...@gmail.com <da...@gmail.com> #31
Please advise if possible on a solution. Thank you in advance.
[Deleted User] <[Deleted User]> #32
// id "com.android.application"
// id "kotlin-android"
// id "dev.flutter.flutter-gradle-plugin"
//}
def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
localPropertiesFile.withReader('UTF-8') { reader ->
localProperties.load(reader)
}
}
def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
flutterVersionCode = '1'
}
def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
flutterVersionName = '1.0'
}
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'com.google.gms.google-services'
//apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
android {
namespace "com.example.notification_fiebase"
compileSdkVersion 33
ndkVersion flutter.ndkVersion
compileOptions {
coreLibraryDesugaringEnabled true
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
kotlinOptions {
jvmTarget = '1.8'
}
sourceSets {
main.java.srcDirs += 'src/main/kotlin'
}
defaultConfig {
multiDexEndabled true
// TODO: Specify your own unique Application ID (
applicationId "com.example.notification_fiebase"
// You can update the following values to match your application needs.
// For more information, see:
minSdkVersion 19
targetSdkVersion flutter.targetSdkVersion
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
}
buildTypes {
release {
// TODO: Add your own signing config for the release build.
// Signing with the debug keys for now, so `flutter run --release` works.
signingConfig signingConfigs.debug
}
}
}
flutter {
source '../..'
}
dependencies {
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
implementation "com.google.firebase:firebase-bom:32.7.1"
}
'flutter' for extension 'android' of type com.android.build.gradle.internal.dsl.BaseAppModuleExtension.
solve that issue
Description
DESCRIBE THE ISSUE IN DETAIL:
While Gradle 7.2 works fine, and Gradle 7.4 works fine in AS 2021.1.1, Gradle 7.4 fails in AS 2021.3.1 Canary 7 with the following exception:
STEPS TO REPRODUCE:
ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE
ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)
Build: AI-213.6777.52.2113.8305692, 202203160046,
AI-213.6777.52.2113.8305692, JRE 11.0.13+0-b1751.21-8125866x64 JetBrains s.r.o., OS Mac OS X(aarch64) v12.3, screens 3456.0x2234.0, 5120.0x2880.0; Retina
AS: Dolphin | 2021.3.1 Canary 7; Kotlin plugin: 213-1.6.20-M1-release-for-android-studio-AS6777.52; Android Gradle Plugin: 7.1.2; Gradle: 7.4; Gradle JDK: version 11.0.13; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: 3.18.1-g262b901, from PATH: 3.22.0