Compose dialog crashes with hardware back button [226552301]

Fixed

Bug

Status Update

No update yet.

Description

er...@gmail.com

created issue #1

Mar 24, 2022 07:06PM

Component used: Navigation Version used: 2.4.1 Devices/Android versions reproduced on: Pixel 3XL and Pixel C emulator

Attached sample project to trigger the crash.

Repro steps: Use the attached sample

run the app
tap the profile button in the top app bar (person icon)
the dialog will show
tap the hardware back button on the device (or tapping outside the dialog) crash

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.test.prototype.composedialognavigation, PID: 13786
    java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
        at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:192)
        at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:106)
        at androidx.navigation.compose.NavHostKt$NavHost$5.invoke(Unknown Source:13)
        at androidx.navigation.compose.NavHostKt$NavHost$5.invoke(Unknown Source:10)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:140)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2158)
        at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:2404)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:2585)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:2571)
        at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:247)
        at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
        at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:2571)
        at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Composer.kt:2547)
        at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:620)
        at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.kt:786)
        at androidx.compose.runtime.Recomposer.access$performRecompose(Recomposer.kt:105)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:456)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:425)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:947)
        at android.view.Choreographer.doCallbacks(Choreographer.java:761)
        at android.view.Choreographer.doFrame(Choreographer.java:693)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:935)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6669)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

ComposeDialogNavigation.zip

537 KB

Download

Comments

er...@gmail.com <er...@gmail.com> #2Mar 25, 2022 03:46PM

I believe I'm having a related problem on certain devices. I set the systemBarBehavior as seen in line below:

WindowInsetsControllerCompat(window, main_container).systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE

Although I'm setting the system bar behavior to BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE, it seems to be behaving as BEHAVIOR_SHOW_BARS_BY_TOUCH on some devices. After i hide the system UI (see fun below) then touch the screen the bottom system navigation bar appears (the status bar remains hidden). When i swipe down from the top, the system status bar does appear transparent and goes away after a few seconds but the bottom system nav bar remains and isn't transparent.

Bug appears on: Galaxy s9+ (android 10), Galaxy Note 10+ (android 10). Bug does not appear on: Google Pixel 3a (android 11), Google Pixel 3 (android 11). I haven't tested on any other devices besides Galaxy s6 but that phone has hardware buttons so it doesn't apply.

Here's my code to go into full screen mode:

// Hide the app action bar, system status bar and system navigation bar
private fun hideSystemUI() {
    supportActionBar?.hide()
    WindowCompat.setDecorFitsSystemWindows(window, false)
    WindowInsetsControllerCompat(window, main_container).let { controller ->
        controller.hide(WindowInsetsCompat.Type.statusBars() or WindowInsetsCompat.Type.navigationBars())
        controller.systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
    }
}

jb...@google.com <jb...@google.com> Apr 5, 2022 07:49PM

Assigned to jb...@google.com.

il...@google.com <il...@google.com> #3Apr 5, 2022 11:08PM

Bug described above (where any touch on the screen reveals the bottom navigation bar) happens on Nokia 7.2 as well

ap...@google.com <ap...@google.com> #4Apr 13, 2022 04:20PM

Bug described above (where any touch on the screen reveals the bottom navigation bar) happens on Xiaomi Redmi Note 9S using Android 10 (MIUI 12) as well.

jb...@google.com <jb...@google.com> #5Apr 13, 2022 04:21PM

Marked as fixed.

Bug described above (where any touch on the screen reveals the bottom navigation bar) happens on Moto one power (Android 10) as well

Issue 226552301