[FR] Shorten PerformanceMetricsState.MetricsStateHolder [226565716]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Mar 24, 2022 02:03PM

Since we're in alpha still, could we shorten the represented naming?

val metricsStateHolder: PerformanceMetricsState.MetricsStateHolder = PerformanceMetricsState.getForHierarchy(someView)

move the class out of the PerformanceMetricsState?
shorten the name to e.g. Holder? (PerformanceMetricsState.Holder)
other option?

Comments

ch...@google.com <ch...@google.com> #2Mar 25, 2022 06:18PM

Fixed in https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3031649

Added itemColors function to NavigationSuiteDefaults so developers can do like so:

val itemColors = NavigationSuiteDefaults.itemColors(/* change only what they want to change*/)

NavigationSuiteScaffold(
  navigationSuiteItems = {
    item(
      ... 
      colors = itemColors
    )
  },
){...}

ap...@google.com <ap...@google.com> #3May 9, 2022 10:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3-adaptive-navigation-suite:1.0.0-alpha06
androidx.compose.material3:material3-adaptive-navigation-suite-android:1.0.0-alpha06
androidx.compose.material3:material3-adaptive-navigation-suite-desktop:1.0.0-alpha06

ch...@google.com <ch...@google.com> May 9, 2022 11:20PM

Marked as fixed.

Issue 226565716

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> #2Mar 25, 2022 06:18PM

ap...@google.com <ap...@google.com> #3May 9, 2022 10:16PM

ch...@google.com <ch...@google.com> May 9, 2022 11:20PM

Add comment

Issue metadata