Fragment 1.5.0-alpha04 crashes when using Splashscreen theme [226648941]

Fixed

Bug

Status Update

No update yet.

Description

st...@gmail.com

created issue #1

Mar 25, 2022 03:59PM

Component used: Fragment

Version used: 1.5.0-alpa04

Devices/Android versions reproduced on: API 23 until API 31

When the app is using the new Theme.SplashScreen from the AndroidX Splashscreen component then the app crashes on startup:

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.myapp/com.myapp.MainActivity}: java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity.
  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3635)
  at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3792)
  at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103)
  at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
  at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2210)
  at android.os.Handler.dispatchMessage(Handler.java:106)
  at android.os.Looper.loopOnce(Looper.java:201)
  at android.os.Looper.loop(Looper.java:288)
  at android.app.ActivityThread.main(ActivityThread.java:7839)
  at java.lang.reflect.Method.invoke(Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
Caused by: java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity.
  at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:852)
  at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:815)
  at androidx.appcompat.app.AppCompatDelegateImpl.initWindowDecorActionBar(AppCompatDelegateImpl.java:556)
  at androidx.appcompat.app.AppCompatDelegateImpl.getSupportActionBar(AppCompatDelegateImpl.java:543)
  at androidx.appcompat.app.AppCompatDelegateImpl.invalidateOptionsMenu(AppCompatDelegateImpl.java:1226)
  at androidx.appcompat.app.AppCompatActivity.invalidateOptionsMenu(AppCompatActivity.java:314)
  at androidx.activity.ComponentActivity.invalidateMenu(ComponentActivity.java:545)
  at androidx.activity.ComponentActivity$$ExternalSyntheticLambda2.run(Unknown Source:2)
  at androidx.core.view.MenuHostHelper.addMenuProvider(MenuHostHelper.java:116)
  at androidx.activity.ComponentActivity.addMenuProvider(ComponentActivity.java:523)
  at androidx.fragment.app.FragmentActivity$HostCallbacks.addMenuProvider(FragmentActivity.java:736)
  at androidx.fragment.app.FragmentManager.attachController(FragmentManager.java:2758)
  at androidx.fragment.app.FragmentController.attachHost(FragmentController.java:117)
  at androidx.fragment.app.FragmentActivity.lambda$init$3$androidx-fragment-app-FragmentActivity(FragmentActivity.java:140)
  at androidx.fragment.app.FragmentActivity$$ExternalSyntheticLambda0.onContextAvailable(Unknown Source:2)
  at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99)
  at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352)
  at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217)
  at com.myapp.MainActivity.onCreate(MainActivity.kt:49)
  at android.app.Activity.performCreate(Activity.java:8051)
  at android.app.Activity.performCreate(Activity.java:8031)
  at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1329)
  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3608)
  at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3792) 
  at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103) 
  at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) 
  at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) 
  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2210) 
  at android.os.Handler.dispatchMessage(Handler.java:106) 
  at android.os.Looper.loopOnce(Looper.java:201) 
  at android.os.Looper.loop(Looper.java:288) 
  at android.app.ActivityThread.main(ActivityThread.java:7839) 
  at java.lang.reflect.Method.invoke(Native Method) 
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) 
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

The relevant lines in MainActivity.kt:

override fun onCreate(savedInstanceState: Bundle?) {
  super.onCreate(savedInstanceState)
  installSplashScreen()
  viewBinding = MainActivityBinding.inflate(layoutInflater)
  setContentView(viewBinding.root)
  // etc.
}

Comments

jb...@google.com <jb...@google.com> #2Mar 25, 2022 05:18PM

Please include a sample project that reproduces your issue.

st...@gmail.com <st...@gmail.com> #3Mar 28, 2022 02:44PM

Here is the sample project.

Steps to reproduce:
1. Press on "Search" icon;
2. Write something;
3. Search this text, keyboard will be dismissed;
4. Tap on "Dialog" button;
5. Dissmiss dialog;

With the new 1.5.0 fragment library version text will be cleared in the search box after dismissing dialog.
In the version 1.4.1 and lower text in the search is not clearing and this is correct behaviour.

Please suggest some workarounds or how to fix this issue?

ta...@mercury.com <ta...@mercury.com> #4Mar 28, 2022 10:17PM

Hello, have you checked sample project? I hope it will help find the issue.

il...@google.com <il...@google.com> #5Mar 30, 2022 05:39PM

Marked as fixed, reassigned to il...@google.com.

@3
I've described a weird workaround that I got, here:

https://issuetracker.google.com/issues/244854449#comment3
Sample:

https://issuetracker.google.com/issues/244854449#comment4

It probably has bugs of its own that I didn't think of.
Google please fix this.

Issue 226648941

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> #2Mar 25, 2022 05:18PM

st...@gmail.com <st...@gmail.com> #3Mar 28, 2022 02:44PM

ta...@mercury.com <ta...@mercury.com> #4Mar 28, 2022 10:17PM

il...@google.com <il...@google.com> #5Mar 30, 2022 05:39PM

Add comment

Issue metadata