[Testing] Improve rule.waitUntil API to accept a matcher [226934294]

Fixed

Feature Request

Status Update

No update yet.

Description

ja...@google.com

created issue #1

Mar 25, 2022 05:42PM

Feature request for improved waitUntil APIs.

Currently, ComposeTestRule's waitUntil function takes a condition lambda that produces a boolean.

This can be used to very effectively and easily synchronize a test with a UI by adding statements such as:

composeTestRule.waitUntil {
    composeTestRule
        .onAllNodesWithText("Welcome")
        .fetchSemanticsNodes().size == 1
}

Making this functionality generic to accept any matcher and any count of nodes would be easy with:


fun ComposeContentTestRule.waitUntilNodeCount(
    matcher: SemanticsMatcher,
    count: Int,
    timeoutMillis: Long = 1_000L
) {
    this.waitUntil(timeoutMillis) {
        this.onAllNodes(matcher).fetchSemanticsNodes().size == count
    }
}

Plus some sugar:

fun ComposeContentTestRule.waitUntilExists(
    matcher: SemanticsMatcher,
    timeoutMillis: Long = 1_000L
) {
    return this.waitUntilNodeCount(matcher, 1, timeoutMillis)
}

fun ComposeContentTestRule.waitUntilDoesNotExist(
    matcher: SemanticsMatcher,
    timeoutMillis: Long = 1_000L
) {
    return this.waitUntilNodeCount(matcher, 0, timeoutMillis)
}

Usage:

composeTestRule.waitUntilExists(hasText("Continue"))

More details and options in (internal doc): go/compose-test-waituntil-proposal

Comments

iz...@google.com <iz...@google.com> Jun 27, 2022 08:54AM

Reassigned to iz...@google.com.

iz...@google.com <iz...@google.com> Jul 21, 2022 04:00PM

Accepted by iz...@google.com.

iz...@google.com <iz...@google.com> #2Aug 22, 2022 08:53AM

Assigned to je...@google.com.

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

ar...@gmail.com <ar...@gmail.com> #3Nov 5, 2022 04:54AM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

ar...@gmail.com <ar...@gmail.com> #4Nov 6, 2022 05:06AM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

ap...@google.com <ap...@google.com> #5Jan 26, 2023 02:20PM

deleted

ja...@google.com <ja...@google.com> #6Mar 22, 2023 11:41AM

Marked as fixed.

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.