Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 2930942005e8fe176ffdda870f2c73debf1461ab
Author: Alex Vanyo <vanyo@google.com>
Date: Wed Apr 20 23:47:30 2022
Add material3-lint and ScaffoldPaddingDetector
This CL adds the material3-lint library (automatically included in
material3) and the first rule, ScaffoldPaddingDetector for when the
inner padding parameter for a Scaffold isn't used.
This is mostly a copy of
https://android-review.googlesource.com/c/platform/frameworks/support/+/2017215
with changes to be for material3 and adding the new module.
Relnote: "Add lint check to material3/Scaffold to ensure that the inner
padding is used"
Test: New tests in :compose:material3:material3:lint
Fixes: 226951418
Change-Id: I72293ba593b57caaacee5d86702b10b281b0246c
A compose/material3/material3-lint/src/test/java/androidx/compose/material3/lint/ApiLintVersionsTest.kt
M settings.gradle
M compose/material/material-lint/src/main/java/androidx/compose/material/lint/ScaffoldPaddingDetector.kt
A compose/material3/material3-lint/src/main/java/androidx/compose/material3/lint/Material3IssueRegistry.kt
M compose/lint/common/src/main/java/androidx/compose/lint/Names.kt
M compose/material/material-lint/src/main/java/androidx/compose/material/lint/ColorsDetector.kt
A compose/material3/material3-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
A compose/material/material-lint/src/main/java/androidx/compose/material/lint/MaterialNames.kt
A compose/material3/material3-lint/build.gradle
M compose/material3/material3/build.gradle
A compose/material3/material3-lint/src/main/java/androidx/compose/material3/lint/ScaffoldPaddingDetector.kt
M compose/lint/common-test/src/main/java/androidx/compose/lint/test/Stubs.kt
A compose/material3/material3-lint/src/main/java/androidx/compose/material3/lint/Material3Names.kt
M compose/material/material-lint/src/test/java/androidx/compose/material/lint/ScaffoldPaddingDetectorTest.kt
A compose/material3/material3-lint/src/test/java/androidx/compose/material3/lint/ScaffoldPaddingDetectorTest.kt
https://android-review.googlesource.com/2070152
Branch: androidx-main
commit 2930942005e8fe176ffdda870f2c73debf1461ab
Author: Alex Vanyo <vanyo@google.com>
Date: Wed Apr 20 23:47:30 2022
Add material3-lint and ScaffoldPaddingDetector
This CL adds the material3-lint library (automatically included in
material3) and the first rule, ScaffoldPaddingDetector for when the
inner padding parameter for a Scaffold isn't used.
This is mostly a copy of
with changes to be for material3 and adding the new module.
Relnote: "Add lint check to material3/Scaffold to ensure that the inner
padding is used"
Test: New tests in :compose:material3:material3:lint
Fixes: 226951418
Change-Id: I72293ba593b57caaacee5d86702b10b281b0246c
A compose/material3/material3-lint/src/test/java/androidx/compose/material3/lint/ApiLintVersionsTest.kt
M settings.gradle
M compose/material/material-lint/src/main/java/androidx/compose/material/lint/ScaffoldPaddingDetector.kt
A compose/material3/material3-lint/src/main/java/androidx/compose/material3/lint/Material3IssueRegistry.kt
M compose/lint/common/src/main/java/androidx/compose/lint/Names.kt
M compose/material/material-lint/src/main/java/androidx/compose/material/lint/ColorsDetector.kt
A compose/material3/material3-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
A compose/material/material-lint/src/main/java/androidx/compose/material/lint/MaterialNames.kt
A compose/material3/material3-lint/build.gradle
M compose/material3/material3/build.gradle
A compose/material3/material3-lint/src/main/java/androidx/compose/material3/lint/ScaffoldPaddingDetector.kt
M compose/lint/common-test/src/main/java/androidx/compose/lint/test/Stubs.kt
A compose/material3/material3-lint/src/main/java/androidx/compose/material3/lint/Material3Names.kt
M compose/material/material-lint/src/test/java/androidx/compose/material/lint/ScaffoldPaddingDetectorTest.kt
A compose/material3/material3-lint/src/test/java/androidx/compose/material3/lint/ScaffoldPaddingDetectorTest.kt
Description
Add a lint check to the material3 Scaffold if the content padding parameter in unused.
This would be very similar to the material Scaffold lint check fromhttps://android-review.googlesource.com/c/platform/frameworks/support/+/2017215 , but the equivalent
material3-lint
artifact doesn't exist yet.