SafeArgs Plugin v2.5.0-alpha03 fails when manifest is not immediately available [227229815]

Fixed

Bug

Status Update

No update yet.

Description

pa...@nearside.com

created issue #1

Mar 28, 2022 08:30PM

Component used: Navigation Version used: 2.5.0-alpha03

If you set up an Android library module with NO MANIFEST and the following android block:

android { 
    namespace = "com.some.package"
}

SafeArgs throws the following error:

Caused by: java.io.FileNotFoundException: /Users/parth/nearside-android/features/dashboard/src/main/AndroidManifest.xml (No such file or directory)
	at androidx.navigation.safeargs.gradle.SafeArgsPlugin.rFilePackage(SafeArgsPlugin.kt:145)
	at androidx.navigation.safeargs.gradle.SafeArgsPlugin.access$rFilePackage(SafeArgsPlugin.kt:41)
        at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$2.invoke$lambda-4(SafeArgsPlugin.kt:106)
	at org.gradle.api.internal.tasks.DefaultTaskContainer.create(DefaultTaskContainer.java:362)
	at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$2.invoke(SafeArgsPlugin.kt:93)
	at androidx.navigation.safeargs.gradle.SafeArgsPlugin$apply$2.invoke(SafeArgsPlugin.kt:92)
	at androidx.navigation.safeargs.gradle.SafeArgsPlugin.forEachVariant$lambda-1(SafeArgsPlugin.kt:55)

This is surprising, because of the following line in the docs:

If you set the namespace in the build.gradle file and no other data needs to be specified, then the library doesn’t need a manifest file.

(source: https://developer.android.com/studio/publish-library/prep-lib-release)

I've created a small sample project showing this error, attached to the ticket.

SafeArgsBug.zip

118 KB

Download

Comments

il...@google.com <il...@google.com> Mar 28, 2022 08:32PM

Assigned to jb...@google.com.

pa...@nearside.com <pa...@nearside.com> #2Mar 28, 2022 08:37PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Mar 31, 2022 12:43AM

Project: platform/frameworks/support
Branch: androidx-main

commit 76ec9528630c52327c3abf0cac85dfb384f4ecb4
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 30 15:30:01 2022

Allow using SafeArgs with no manifest file

Gradle now supports namespaces and with namespaces it is possible to
completely remove the manifest if it is not being used. SafeArgs
supports using namespace now and should not crash if the manifest is not
present.

RelNote: "`Navigation Safe Args` will no longer crash when using
namespaces and no `AndroidManifest.xml` is present."
Test: tested in sample app
Bug: 227229815

Change-Id: I17ccf95b5f4137762d7c3db0503ec394812e89e8

M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt

https://android-review.googlesource.com/2050754

jb...@google.com <jb...@google.com> #4Mar 31, 2022 12:44AM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.5.0-alpha04 and 2.4.2 releases.

Issue 227229815

Description

Issue summary

Comments

il...@google.com <il...@google.com> Mar 28, 2022 08:32PM

pa...@nearside.com <pa...@nearside.com> #2Mar 28, 2022 08:37PM

ap...@google.com <ap...@google.com> #3Mar 31, 2022 12:43AM

jb...@google.com <jb...@google.com> #4Mar 31, 2022 12:44AM

Add comment

Issue metadata