Fixed
Status Update
No update yet.
Comments
ap...@google.com
The horizontal analogue of LazyVerticalGrid
il...@google.com
il...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 0d76cb8cdde123c08a05390a01a6a3d9d599c270
Author: Mihai Popa <popam@google.com>
Date: Tue Feb 22 13:56:58 2022
Add LazyHorizontalGrid
Relnote: "LazyHorizontalGrid was added."
Fixes: 191238807
Test: new tests in lazy.grid
Change-Id: I61ae7abe269fdb3776c301dd5c233762f9766f4d
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridAnimateItemPlacementTest.kt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyGrid.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridItemPlacementAnimator.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/LazyGridSamples.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredItem.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGrid.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyArrangementsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredLine.kt
https://android-review.googlesource.com/1994930
Branch: androidx-main
commit 0d76cb8cdde123c08a05390a01a6a3d9d599c270
Author: Mihai Popa <popam@google.com>
Date: Tue Feb 22 13:56:58 2022
Add LazyHorizontalGrid
Relnote: "LazyHorizontalGrid was added."
Fixes: 191238807
Test: new tests in lazy.grid
Change-Id: I61ae7abe269fdb3776c301dd5c233762f9766f4d
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridAnimateItemPlacementTest.kt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyGrid.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridItemPlacementAnimator.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/LazyGridSamples.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredItem.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGrid.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyArrangementsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredLine.kt
to...@yahoo.com
gr...@gmail.com
Hello. Why do you write than the contract for onPrepareMenu is "called when the menu is first shown"?
From documentation:
Called by the MenuHost right before the Menu is shown. This should be called when the menu has been dynamically updated.
There aren't mentions about first showing. For example ComponentActivity implementation of MenuHost call onPrepareMenu before every show of menu. And, imho, this behaviour makes much more sense.
For now Toolbar implementation is inconsistent and misleading.
to...@yahoo.com
#5 : badly worded I guess (been a while)
but it's been fixed properly now in
gr...@gmail.com
Great, thanks for answer!
Description
Now that the
MenuProviderinterface contains the optionalonPrepareMenu()API to maintain 1:1 compatibility, we want to make sure thatToolbar'sMenuHostHelperutilizes this API in case developers choose to implement it when adding aMenuProvider.