IssueTracker

Great! Thanks a lot, I'll look for the live updates soon!

urm... that's not a proper fix?

Please may I remind you about the contract for onPrepareMenu: called when the menu is first shown

But in your code, you now simply call onPrepareMenu during the onCreateMenu phase.

I realise that Toolbar did/does not implement onPrepareMenu properly up to now, but it never promised to do, so that was ok up to now.

However, if you're adding support for MenuProvider (thank you!) then it has to be implemented such that it's contract is fulfilled. Right now, the contract of the MenuProvider is broken in Toolbar.

Hello. Why do you write than the contract for onPrepareMenu is "called when the menu is first shown"?

From documentation:

Called by the MenuHost right before the Menu is shown. This should be called when the menu has been dynamically updated.

There aren't mentions about first showing. For example ComponentActivity implementation of MenuHost call onPrepareMenu before every show of menu. And, imho, this behaviour makes much more sense.

For now Toolbar implementation is inconsistent and misleading.

#5 : badly worded I guess (been a while)

but it's been fixed properly now in https://issuetracker.google.com/issues/232206677

Great, thanks for answer!