lintVital target run by default in a debug variant [227811110]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

tn...@google.com

created issue #1

Apr 1, 2022 11:44PM

I was building a sample project with 7.3 dev, and as I was trying to run the app, the build failed with a lint error. I was not expecting this, because the current variant is a debug variant, and lintVital should only be running on release variants. See screenshot. The test project is https://github.com/android/architecture-samples though I have some local tweaks (but not to the variants setup).

Executing tasks: [:app:assembleMockDebug] in project /Users/tnorbye/demo/projects/architecture-samples

Starting Gradle Daemon...
Gradle Daemon started in 594 ms
> Task :app:createMockDebugVariantModel UP-TO-DATE
> Task :app:preBuild UP-TO-DATE
....
(deleted many lines)
....
> Task :app:packageMockDebug
> Task :app:createMockDebugApkListingFileRedirect

> Task :app:lintVitalAnalyzeMockDebug
Index data read correctly

> Task :app:lintVitalReportMockDebug

> Task :app:lintVitalMockDebug FAILED
/Users/tnorbye/demo/projects/architecture-samples/app/src/mock/java/com/example/android/architecture/blueprints/todoapp/data/FakeTasksRemoteDataSource.kt:36: Error: Expected non-nullable value [NullSafeMutableLiveData from jetified-lifecycle-livedata-core-ktx-2.4.1]
        observableTasks.postValue(getTasks())
                                  ~~~~~~~~~~

Build: AI-213.7172.25.2113.SNAPSHOT, 202204011615,

AI-213.7172.25.2113.SNAPSHOT, JRE 11.0.13+0-b1751.21-8125866x64 JetBrains s.r.o., OS Mac OS X(aarch64) v12.3.1, screens 3456.0x2234.0; Retina

AS: dev build; Kotlin plugin: 213-1.6.20-M1-release-for-android-studio-AS6777.52; Android Gradle Plugin: 7.3.0-alpha07; Gradle: 7.4; Gradle JDK: version 11.0.13; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Screen Shot 2022-04-01 at 4.39.20 PM.png

1.9 MB

View

Download

Comments

tn...@google.com <tn...@google.com> #2Apr 2, 2022 02:24AM

Reassigned to lu...@google.com.

As I understand it, we need to migrate namespace definitions both from AndroidManifest.xml and from implicit definitions from applicationId / testApplicationId? Is that right? So an 8.0 project would have a

namespace <n>
testNamespace <tn>

where <n> is taken from AndroidManifest.xml package definitions if present, and applicationId if not, and <tn> is testApplicationId if present and <n>.test if not?

yi...@google.com <yi...@google.com> Apr 2, 2022 04:38AM

Reassigned to yi...@google.com.

yi...@google.com <yi...@google.com> #3Apr 9, 2022 12:00AM

Sorry for the confusion. AGP would change how it computes the namespace for the androidTest variant. All the Upgrade assistant would need to do is update the source code for the import of the R class.

lu...@google.com <lu...@google.com> #4Apr 14, 2022 02:37PM

OK! And, I think, this should happen at the same time as the namespace declaration is migrated from AndroidManifest.xml?

cm...@google.com <cm...@google.com> Sep 26, 2022 03:05PM

Accepted by cm...@google.com.

cm...@google.com <cm...@google.com> #5Sep 26, 2022 04:20PM

Marked as fixed.

It's unrelated, but it is possible that we move 8.0 to also only declare the namespace into the DSL. I would make it a separate refactoring because they are not tied at all.

Issue 227811110