lintVital target run by default in a debug variant [227811110]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

tn...@google.com

created issue #1

Apr 1, 2022 11:44PM

I was building a sample project with 7.3 dev, and as I was trying to run the app, the build failed with a lint error. I was not expecting this, because the current variant is a debug variant, and lintVital should only be running on release variants. See screenshot. The test project is https://github.com/android/architecture-samples though I have some local tweaks (but not to the variants setup).

Executing tasks: [:app:assembleMockDebug] in project /Users/tnorbye/demo/projects/architecture-samples

Starting Gradle Daemon...
Gradle Daemon started in 594 ms
> Task :app:createMockDebugVariantModel UP-TO-DATE
> Task :app:preBuild UP-TO-DATE
....
(deleted many lines)
....
> Task :app:packageMockDebug
> Task :app:createMockDebugApkListingFileRedirect

> Task :app:lintVitalAnalyzeMockDebug
Index data read correctly

> Task :app:lintVitalReportMockDebug

> Task :app:lintVitalMockDebug FAILED
/Users/tnorbye/demo/projects/architecture-samples/app/src/mock/java/com/example/android/architecture/blueprints/todoapp/data/FakeTasksRemoteDataSource.kt:36: Error: Expected non-nullable value [NullSafeMutableLiveData from jetified-lifecycle-livedata-core-ktx-2.4.1]
        observableTasks.postValue(getTasks())
                                  ~~~~~~~~~~

Build: AI-213.7172.25.2113.SNAPSHOT, 202204011615,

AI-213.7172.25.2113.SNAPSHOT, JRE 11.0.13+0-b1751.21-8125866x64 JetBrains s.r.o., OS Mac OS X(aarch64) v12.3.1, screens 3456.0x2234.0; Retina

AS: dev build; Kotlin plugin: 213-1.6.20-M1-release-for-android-studio-AS6777.52; Android Gradle Plugin: 7.3.0-alpha07; Gradle: 7.4; Gradle JDK: version 11.0.13; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Screen Shot 2022-04-01 at 4.39.20 PM.png

1.9 MB

View

Download

Comments

tn...@google.com <tn...@google.com> #2Apr 2, 2022 02:24AM

Reassigned to lu...@google.com.

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

yi...@google.com <yi...@google.com> Apr 2, 2022 04:38AM

Reassigned to yi...@google.com.

yi...@google.com <yi...@google.com> #3Apr 9, 2022 12:00AM

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

lu...@google.com <lu...@google.com> #4Apr 14, 2022 02:37PM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

cm...@google.com <cm...@google.com> Sep 26, 2022 03:05PM

Accepted by cm...@google.com.

cm...@google.com <cm...@google.com> #5Sep 26, 2022 04:20PM

Marked as fixed.

I will backport this to the 8.0 and 4.0 branches.

Issue 227811110

Description

Issue summary

Comments

tn...@google.com <tn...@google.com> #2Apr 2, 2022 02:24AM

yi...@google.com <yi...@google.com> Apr 2, 2022 04:38AM

yi...@google.com <yi...@google.com> #3Apr 9, 2022 12:00AM

lu...@google.com <lu...@google.com> #4Apr 14, 2022 02:37PM

cm...@google.com <cm...@google.com> Sep 26, 2022 03:05PM

cm...@google.com <cm...@google.com> #5Sep 26, 2022 04:20PM

Add comment

Issue metadata