Fixed
Status Update
Comments
we...@google.com <we...@google.com> #2
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
we...@google.com <we...@google.com> #3
Great! Thanks a lot, I'll look for the live updates soon!
so...@gmail.com <so...@gmail.com> #4
Thank you for fixing this. Will this be available in the next version of Camera-X?
Regards
Regards
we...@google.com <we...@google.com> #5
Hello, the fix would be in the next cut of the alpha release, it probably would happen around early June.
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit c0d45ec4b139bd56eef44f1be88e922623090d97
Author: WenHung_Teng <wenhungteng@google.com>
Date: Tue May 10 16:32:39 2022
Fix torch is unexpectedly closed after image capture issue
The affected devices may close the torch if the still
capture request contains the FLASH_MODE_TORCH option. And the
torch will stay off even when the repeating request reports
the flash mode is FLASH_MODE_TORCH.
*) Create a Quirk for the devices encounter this issue
*) Submit a single request to turn Torch Off, and then, the
FLASH_MODE_TORCH option in the repeating request will turn it
on again.
Relnote: "Fixed ImageCapture takePicture method turns torch off on the reported devices."
Bug: 228272227
Test: CamXCoreAppFlashTorchCheckQRCode
Change-Id: Ib5eb52dd4d54dc193013f0296ae62121f5480fcd
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/CaptureSession.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/DeviceQuirksLoader.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/TorchIsClosedAfterImageCapturingQuirk.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/TorchStateReset.java
https://android-review.googlesource.com/2095703
Branch: androidx-main
commit c0d45ec4b139bd56eef44f1be88e922623090d97
Author: WenHung_Teng <wenhungteng@google.com>
Date: Tue May 10 16:32:39 2022
Fix torch is unexpectedly closed after image capture issue
The affected devices may close the torch if the still
capture request contains the FLASH_MODE_TORCH option. And the
torch will stay off even when the repeating request reports
the flash mode is FLASH_MODE_TORCH.
*) Create a Quirk for the devices encounter this issue
*) Submit a single request to turn Torch Off, and then, the
FLASH_MODE_TORCH option in the repeating request will turn it
on again.
Relnote: "Fixed ImageCapture takePicture method turns torch off on the reported devices."
Bug: 228272227
Test: CamXCoreAppFlashTorchCheckQRCode
Change-Id: Ib5eb52dd4d54dc193013f0296ae62121f5480fcd
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/CaptureSession.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/DeviceQuirksLoader.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/TorchIsClosedAfterImageCapturingQuirk.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/TorchStateReset.java
we...@google.com <we...@google.com>
oj...@gmail.com <oj...@gmail.com> #7
I need camera x
Description
Torch was off on some specific Xiaomi model, it can be reproduced on Redmi 4X, Redmi 5A.