Move SparseArray and tests to common [228347315]

Fixed

Feature Request

Status Update

No update yet.

Description

pa...@google.com

created issue #1

Apr 6, 2022 07:01PM

Move all the SparseArray related classes and tests to common src directory.

Comments

yb...@google.com <yb...@google.com> Apr 26, 2022 12:19AM

Assigned to yb...@google.com.

yb...@google.com <yb...@google.com> Apr 26, 2022 03:42PM

Reassigned to du...@google.com.

ap...@google.com <ap...@google.com> #2Apr 27, 2022 09:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit 55ec1c6652f40592d67c8255fb395a6e2b333b1e
Author: Yigit Boyar <yboyar@google.com>
Date: Mon Apr 25 19:57:27 2022

Convert LongSparseArrayTest to kotlin

Also cleaned up some tests to be more readable.

Bug: 228347315
Test: LongSparseArrayTest
Change-Id: Ida0eac0edbe8ba13fa4adcb83b977ea4ab44b676

M collection/collection/src/jvmTest/kotlin/androidx/collection/LongSparseArrayTest.kt

https://android-review.googlesource.com/2076258

ap...@google.com <ap...@google.com> #3Apr 27, 2022 09:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1b55a13d24c20bb0e1b23248661e845e2d8cc5f9
Author: Yigit Boyar <yboyar@google.com>
Date: Mon Apr 25 17:19:24 2022

rename and move LongSparseArrayTest

Bug: 228347315
Test: n/a
Change-Id: I59be198fd1be292ce143692117f726ce3777e592

M collection/collection/src/jvmTest/kotlin/androidx/collection/LongSparseArrayTest.kt

https://android-review.googlesource.com/2075960

ap...@google.com <ap...@google.com> #4Jun 29, 2022 10:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit fa2033f2ca1f0264324e872314a1b41b67729178
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 28 09:32:56 2022

Remove access to System.arrayCopy methods

This is a minor cleanup in preparation for the commonization of LongSparseArray.

Bug: 228347315
Test: LongSparseArrayTest
Change-Id: Ib080e0f39f28dcaf8c37d83e658140bf802290bb

M collection/collection/src/jvmMain/kotlin/androidx/collection/LongSparseArray.kt

https://android-review.googlesource.com/2079824

ap...@google.com <ap...@google.com> #5Jun 29, 2022 10:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit 483dc927a81c321d0fc01ffff1e7fceba9234e5e
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 28 09:21:04 2022

Commonize LongSparseArray

Bug: 228347315
Test: LongSparseArrayTest, LongSparseArrayJvmTest (for clone)

Change-Id: I73149c74661a556e1d8693ebd25f52fe64dca626

M collection/collection/src/commonTest/kotlin/androidx/collection/LongSparseArrayTest.kt
A collection/collection/src/jvmMain/kotlin/androidx/collection/LongSparseArray.jvm.kt
M collection/collection/src/commonMain/kotlin/androidx/collection/LongSparseArray.kt
A collection/collection/src/nativeMain/kotlin/androidx/collection/LongSparseArray.native.kt
A collection/collection/src/jvmTest/kotlin/androidx/collection/LongSparseArrayJvmTest.kt

https://android-review.googlesource.com/2079822

ap...@google.com <ap...@google.com> #6Jun 29, 2022 10:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit c7d33bf93d68f9491672a02faa6e22bf3aedbfd8
Author: Yigit Boyar <yboyar@google.com>
Date: Wed Apr 27 22:26:39 2022

Commonize LongSparseArray

LongSparseArray implements Cloneable, which is not possible in
native, hence we have to duplicate the class into expect-actual
and then move all real logic into inlined common methods.

See KMP bug:

https://youtrack.jetbrains.com/issue/KT-20427

Bug: 228347315
Test: LongSparseArrayTest
Change-Id: If1371556952c0f9a6c45ced7312c89d36a5345b9

M collection/collection/src/jvmMain/kotlin/androidx/collection/LongSparseArray.kt

https://android-review.googlesource.com/2078261

ap...@google.com <ap...@google.com> #7Jul 15, 2022 08:53PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7b83f482e3cab0d7126e66a6dbeb1645dffc27aa
Author: Dustin Lam <dustinlam@google.com>
Date: Wed Jul 13 19:24:27 2022

Commonize SparseArrayCompat

Bug: 219589118
Fixes: 228347315
Test: ./gradlew collection:collection:test
Relnote: "Make SparseArrayCompat available to non-jvm platforms"
Change-Id: Ic9bd08bed81ddc1d902fc9947d6b3f8e5bb4c45f

M collection/collection/api/current.txt
M collection/collection/src/commonMain/kotlin/androidx/collection/SparseArrayCompat.kt
A collection/collection/src/jvmMain/kotlin/androidx/collection/SparseArrayCompat.jvm.kt
D collection/collection/src/jvmTest/java/androidx/collection/SparseArrayCompatTest.java
M collection/collection/src/commonMain/kotlin/androidx/collection/SparseArray.kt
A collection/collection/src/commonTest/kotlin/androidx/collection/SparseArrayCompatTest.kt
A collection/collection/src/jvmTest/java/androidx/collection/SparseArrayCompatJvmTest.kt
M collection/collection/api/public_plus_experimental_current.txt
M collection/collection/api/restricted_current.txt
M collection/collection/build.gradle
A collection/collection/src/nativeMain/kotlin/androidx/collection/SparseArrayCompat.native.kt

https://android-review.googlesource.com/2151732