IssueTracker

Thanks for the detailed description

This seems like a dup of b/183835422

comment#2 is not the same issue.

from b/183835422

Row(modifier = Modifier.fillMaxWidth()) {
    BoxWithText(
        Modifier.weight(1f),
        "Abc ".repeat(1),
    )
    BoxWithText(
        Modifier.weight(1f),
        "Lorem ipsum dolor sit amet",
    )
}
Row(modifier = Modifier.fillMaxWidth()) {
    BoxWithText(
        Modifier.weight(1f),
        "Abc ".repeat(1),
    )
    BoxWithText(
        Modifier.weight(1f),
        "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed nibh lacus, finibus vitae nulla ut, tincidunt fringilla arcu.",
    )
}

Screenshots attached before/after aosp/2175613

cc'ed Anastasia for comment#2

Adding screenshot for the code in comment#1

re:comment #2

we only clipped for Clip overflow. But we fixed this for ellipsis case already in aosp/2170326

I debugged why this happens in the framework and here is my result.

In short, the root cause of this issue is that the line width Layout.java calculated at measure time and draw time was different.

On measure time, the letter spacing is not counted for some reasons (source), and at the draw time the letter spacing is counted(source). The line width is necessary only when it is right aligned (source).

Because we assume this line width is less than constraint's line width but actually not, because the ellipsis point is calculated without letter spacing. For example, the above example on my device has following line widths:

• Constraint line width: 1080px
• Line width until character index 653 without letter spacing (the ellipsis start offset): 1039px
• Line width until character index 653 with letter spacing: 1872px

As the result, this line extent(1082px) is bigger than the constraint line width(1080px), then the drawing offset was shifted 792 px (1872 px - 1080 px).

The correct fix is use the common width calculation when deciding the ellipsis offset and drawing. I agree that this is not fixable in Compose side and workaround is needed.

Thanks Nona

work after aosp/2175613

• fix isLineEllipsized
• check if new paddings can be moved into a new object

fyi: the bug is fixed, there is an internal cleanup waiting.

I have updated compose to 1.3.0-beta01, which apparently includes the fix. Now I am encountering a crash if the text is set to an empty string:

  java.lang.IndexOutOfBoundsException: setSpan (-1 ... -1) starts before 0
                                                                                                    	at android.text.SpannableStringInternal.checkRange(SpannableStringInternal.java:499)
                                                                                                    	at android.text.SpannableStringInternal.setSpan(SpannableStringInternal.java:199)
                                                                                                    	at android.text.SpannableStringInternal.setSpan(SpannableStringInternal.java:186)
                                                                                                    	at android.text.SpannableString.setSpan(SpannableString.java:60)
                                                                                                    	at androidx.compose.ui.text.platform.extensions.SpannableExtensions_androidKt.setSpan(SpannableExtensions.android.kt:85)
                                                                                                    	at androidx.compose.ui.text.AndroidParagraph_androidKt.attachIndentationFixSpan(AndroidParagraph.android.kt:518)
                                                                                                    	at androidx.compose.ui.text.AndroidParagraph_androidKt.access$attachIndentationFixSpan(AndroidParagraph.android.kt:1)
                                                                                                    	at androidx.compose.ui.text.AndroidParagraph.<init>(AndroidParagraph.android.kt:118)
...

thank you for the prompt feedback will fix asap.