NullPointerException AutofillManager [228529893]

Fixed

Bug

Status Update

No update yet.

Description

ge...@housecallpro.com

created issue #1

Apr 8, 2022 10:19PM

Component used: android.view.autofill
Version used:
Devices/Android versions reproduced on:
Galaxy S21 Ultra 5G Android 12

If this is a bug in the library, we would appreciate if you could attach:

Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.os.Bundle.containsKey(java.lang.String)' on a null object reference
at android.view.autofill.AutofillManager.onAuthenticationResult(AutofillManager.java:1798)
at android.app.Activity.dispatchActivityResult(Activity.java:8674)
at android.app.ActivityThread.deliverResults(ActivityThread.java:5841)
at android.app.ActivityThread.handleSendResult(ActivityThread.java:5887)
at android.app.servertransaction.ActivityResultItem.execute(ActivityResultItem.java:54)
at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2425)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:226)
at android.os.Looper.loop(Looper.java:313)
at android.app.ActivityThread.main(ActivityThread.java:8582)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:563)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1133)

- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Comments

is...@google.com <is...@google.com> Apr 10, 2022 07:05AM

Status: New

sz...@gmail.com <sz...@gmail.com> #2Apr 19, 2022 06:46AM

P.S. Actually we cannot running Instrumented Test when using NavigationUI.
When initialize the AppBarConfiguration, it will call the final method of NavGraph (findNode) and we cannot mock it.

an...@northwesternmutual.com <an...@northwesternmutual.com> #3Apr 22, 2022 04:20PM

I also ran into this today while trying to add a FragmentScenario test. Followed the testing documentation and arrived at the same place. AppBarConfiguration attempts to interact with NavGraph and crashes.

vo...@gmail.com <vo...@gmail.com> #4Apr 27, 2022 07:41AM

Yep, we should have a better testing story that doesn't depend on using mocks.

ca...@gmail.com <ca...@gmail.com> #5May 5, 2022 08:43PM

One and only solution is to use Mockito in Espresso tests. Which is actually is almost equal to no solution. We strictly do not use Mockito in our integrations tests running on devices because that is very fragile and causes huge amount of issues when using on different SDK versions. This makes Navigation lib no go for us.

So current situation:
- Navigation library is already released with stable API.
- API is created without test-ability in mind. Huge classes with large amount of public methods, no interfaces. Using such tools as Mockito is not a solution, but workaround for situations when API is not testable.

After 10 years of creating un-testable Android SDKs there was possibility to have clean slate opportunity. And here we go again. API released and needs to be maintained now. Please recognize this problem now and bump priority from lowest (P3) to something higher. Because until we won't have possibility to test our app navigation flows we can't use this library.

Message last modified on May 5, 2022 08:44PM

di...@chargepoint.com <di...@chargepoint.com> #6May 17, 2022 09:54AM

We'll be releasing a dedicated navigation-testing artifact in Navigation 2.3.0-alpha01 that provides additional testing specific APIs

This work includes:

Among other changes.

[Deleted User] <[Deleted User]> #7May 18, 2022 01:43PM

For your information the stack trace points to AutofillManager.java#1798@android-12-release, which reads:

if (data.getExtras().containsKey(EXTRA_AUTHENTICATION_RESULT_EPHEMERAL_DATASET)) {
    responseData.putBoolean(EXTRA_AUTHENTICATION_RESULT_EPHEMERAL_DATASET,
            data.getBooleanExtra(EXTRA_AUTHENTICATION_RESULT_EPHEMERAL_DATASET,
                    false));
}

This if-statement was introduced in Android 12 and crashes because data.getExtras() returns null. The documentation for EXTRA_AUTHENTICATION_RESULT_EPHEMERAL_DATASET (link) implies that they have tested the null-case:

In Build.VERSION_CODES.S, we added this boolean extra field to allow the AutofillService to explicitly specify whether the returned authenticated Dataset is ephemeral. An ephemeral Dataset will be used to autofill once and then thrown away. Therefore, when the boolean extra is set to true, the returned Dataset will not replace the old dataset from the existing FillResponse. When it's set to false, it will. When it's not set, the old dataset will be replaced, unless it is a pinned inline suggestion, which is consistent with the behavior in Build.VERSION_CODES.R.

Speculation: Maybe they didn't test with AutofillServices compiled against older API levels? If so this could be triggered by an outdated password manager.

pu...@gmail.com <pu...@gmail.com> #8May 30, 2022 08:02AM

Is there a workaround for this issue ? I've seen it in a WebView spawn by my app leading to login form.

mo...@gmail.com <mo...@gmail.com> #9Jun 6, 2022 07:49AM

I had the same problem because data.getExtras() get null on 12 devices.

ta...@xiaomi.com <ta...@xiaomi.com> #10Jun 8, 2022 12:29AM

have a try?

https://android-review.googlesource.com/c/platform/frameworks/base/+/2115080

jo...@google.com <jo...@google.com> Jun 8, 2022 03:41AM

Assigned to jo...@google.com.

ap...@google.com <ap...@google.com> #11Jun 8, 2022 10:16AM

Project: platform/frameworks/base
Branch: master

commit 1c53e50cf3f0cc60f1bfbda6ce7cad18a0cc0c6f
Author: jiajia tang <tangjiajia@xiaomi.com>
Date: Wed Jun 08 08:20:37 2022

Fix AutofillManager NPE

Bug: 228529893

Change-Id: I2de34b24752eed089ca5d1e34d216c87dc3bf2c6
Signed-off-by: jiajia tang <tangjiajia@xiaomi.com>
Merged-In: If56d690882e8d4ad0dba1534f127478089c4d04f

M core/java/android/view/autofill/AutofillManager.java

https://android-review.googlesource.com/2115080

ca...@gmail.com <ca...@gmail.com> #12Jun 8, 2022 10:30AM

In which release this is expected to come out? Or are there any ways to test it as of today?

jo...@google.com <jo...@google.com> #13Jun 8, 2022 10:38AM

Reassigned to ta...@xiaomi.com.

We don't have Android 12 QPR so it cannot be fixed in Android 12.

We already fix the issue internally, so Android 13 bata3 will have this fix.

jo...@google.com <jo...@google.com> #14Jun 8, 2022 10:40AM

Marked as fixed.

Thanks tangjiajia@xiaomi.com submitting the fix.

ca...@gmail.com <ca...@gmail.com> #15Jun 8, 2022 10:56AM

So for now, across all android 12 devices this will remain as an issue? Until they upgrade to android 13?

jo...@google.com <jo...@google.com> #16Jun 8, 2022 11:02AM

Yeah, our last QPR was already released so we don't have a change to fix it.

[Deleted User] <[Deleted User]> #17Feb 27, 2024 10:47AM

Comment has been deleted.

Message last modified on Feb 27, 2024 03:05PM

deleted

0 B