Using @IntDef in a library component doesn't generate annotations.zip in the aar [228751486]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Apr 11, 2022 01:31PM

When creating a library component that uses @IntDef annotations in its public API, I am expecting that the annotations.zip is packaged inside that aar - from here, it states:

If you use annotations in your own library module, the annotations are included as part of the Android Archive (AAR) artifact in XML format in the annotations.zip file. Adding the support-annotations dependency does not introduce a dependency for any downstream users of your library.

However, this doesn't appear to be the case, and the build/intermediates/annotations_typedef_file/debug/typedefs.txt file is empty (I'm assuming this would contain something?) as is the build/intermediates/annotations_zip/debug/ dir.

I'm using AGP 7.0.3 with Gradle version 7.0.2 in Android Studio Bumblebee 2021.1.1. Patch 2.

(NOTE: I re-raised this ticket, as https://issuetracker.google.com/issues/227147440 was likely in too high-level a bucket. Apologies for the dupe.)

Comments

al...@google.com <al...@google.com> #2Apr 11, 2022 01:47PM

Status: New

Here is the stacktrace:

java.lang.VerifyError: Verifier rejected class WN: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent) failed to verify: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent): [0x4]  can't resolve returned type 'Reference: android.app.Notification$Style' or 'Unresolved Reference: android.app.Notification$CallStyle' (declaration of 'WN' appears in base.apk!classes4.dex)
	at Tj.<init>(SourceFile:17)
	at kT1.<init>(SourceFile:23)
	at aL1.<init>(SourceFile:293)
	at bh4.get(SourceFile:1606)
	at cL1.a(SourceFile:29)
	at cL1.e(SourceFile:17)
	at s1i.getValue(Unknown Source:17)
	at dL1.a(SourceFile:11)
	at RQ1.b(Unknown Source:2)
	at EQ1.execute(SourceFile:15)
	at lU1.handleMessage(SourceFile:18)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at N52.dispatchMessage(SourceFile:7)
	at android.os.Looper.loop(Looper.java:237)
	at android.os.HandlerThread.run(HandlerThread.java:67)

Unfortunately, I can't share the dex2oat logs for this as I'm running into this problem on Android 11 emulator and I don't have a rooted Android 11 device on-hand.

ja...@gmail.com <ja...@gmail.com> #3Apr 11, 2022 01:57PM

Thanks for the report. Can you share the APK failing and give suggestions to force the error such that I can see the entire logcat on device. The outline is looking correct so I believe the error is someplace else and logcat will show that.

em...@google.com <em...@google.com> Apr 11, 2022 03:19PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Apr 11, 2022 07:39PM

Reassigned to bi...@google.com.

bi...@google.com <bi...@google.com> #4Apr 11, 2022 07:54PM

Accepted by bi...@google.com.

I shared the APK and instructions to reproduce over email. Let me know if you have any trouble reproing the crash.

ja...@gmail.com <ja...@gmail.com> #5Apr 11, 2022 10:29PM

Thank you for the dump and information. Turns out that behavior of the verifier changed on Android 11 and 12 but was reverted again. I am working on a fix that should be easy to merge to the 4.0 branch.

Note that the verification error is actually also easy to create by manual outlining, but our pattern just emphasize it.

bi...@google.com <bi...@google.com> #6Sep 28, 2022 05:49PM

Project: r8
Branch: main

commit b7b22190797c9b74218fb1d2fdfb497a9be9fb3b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 13:03:38 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

Change-Id: I2479d669217d90f057fa248fcea0f0f27faf91a6

M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
M src/main/java/com/android/tools/r8/ir/code/Return.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
M src/main/java/com/android/tools/r8/ir/desugar/apimodel/ApiInvokeOutlinerDesugaring.java
A src/main/java/com/android/tools/r8/ir/optimize/RemoveVerificationErrorForUnknownReturnedValues.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineHorizontalMergingTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineInstanceInitializerTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77221

bi...@google.com <bi...@google.com> #7Sep 28, 2022 10:44PM

Marked as fixed.

Project: r8
Branch: main

commit 88dd6ed0006725301bcbe88942e474569c9aa1b1
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 12:43:54 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

Change-Id: I5684a12bf42422bb96122422e063ffd0503fb5e5

M src/main/java/com/android/tools/r8/utils/AndroidApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77180

ja...@gmail.com <ja...@gmail.com> #8Sep 29, 2022 08:28AM

thanks for the fix. if this can be backported to 4.0 that would be great