Vertical Scrolling is interrupted by Horizontal Scrolling [228754545]

Can't Repro

Bug

Status Update

No update yet.

Description

ch...@gmail.com

created issue #1

Apr 11, 2022 05:22AM

Jetpack Compose version:

1.0.1

Jetpack Compose component used:

Rows and Columns

Android Studio Build:

Android Studio Bumblebee | 2021.1.1 Patch 2 Build #AI-211.7628.21.2111.8193401, built on February 17, 2022

Kotlin version:

1.5.32

Code Sample to Reproduce:

 val colors = remember {
                    listOf(
                        Color.Blue,
                        Color.Green,
                        Color.Cyan,
                        Color.Magenta
                    )
                }

                Box(
                    modifier = Modifier

                ) {
                    Column(
                        modifier = Modifier
                            .padding(top = 200.dp)
                            .fillMaxSize()
                            .verticalScroll(rememberScrollState())
                    ) {
                        repeat(5) {
                            Row(
                                modifier = Modifier
                                    .fillMaxWidth()
                                    .padding(8.dp)
                                    .horizontalScroll(rememberScrollState())
                            ) {
                                repeat(5) {
                                    Box(
                                        modifier = Modifier
                                            .size(200.dp)
                                            .background(
                                                color = remember {
                                                    colors.random()
                                                }
                                            )
                                    )
                                }
                            }
                        }
                    }
                }

Steps to Reproduce

check attached video for reference : Scroll/fling vertically, up and down very fast multiple times

video6230782002031756749.mp4

664 KB

Download

Comments

ch...@gmail.com <ch...@gmail.com> #2Apr 11, 2022 05:24AM

Thanks for filling this, HiltViewModelFactory wraps around a SavedStateViewModelFactory which is also the default one for non Hilt injected Fragments and Activities, it seems there is some key conflicts, I'll investigate and comer back with more info soon, thanks for the sample app!

ae...@google.com <ae...@google.com> Apr 12, 2022 11:45PM

Assigned to co...@google.com.

ga...@mistplay.com <ga...@mistplay.com> #3May 18, 2022 04:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d76172ec45a778efe5f46b6ad1a50ae24241d14d
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Jun 16 14:50:23 2020

Avoid SavedStateHandle key conflict in HiltViewModelFactory.

When delegating to the SavedStateViewModelFactory to create
ViewModels that are not Hilt injected, the factory will attempt
to retrieve a SavedStateHandler using a controller with the same
key as the SavedStateHandle passed into the abstract create() method
of AbstractSavedStateViewModelFactory for which the
HiltViewModelFactory implements. Therefore causing a key conflict.

In this change we avoid the key conflict collision by prefixing the
before delegating to SavedStateViewModelFactory. Since ViewModels
will be either create by one or the other factory, it is safe to
mangle the key. Meanwhile, even though the key is also used to
add a tag to the ViewModel for cleanup, the tag is only added
if the key used is not present. When SavedStateViewModelFactory
tags the ViewModel and then a second time in once
AbstractSavedStateViewModelFactory#create() returns, the tag
is not overridden (lucky us).

This fixes a bug when mixing vanilla ViewModels and Hilt injected
ones.

Bug: 158737069
Test: ViewModelApp Integration Tests
Change-Id: I86ae254c2f26795c900317d42041319fd279e545

M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
M hilt/hilt-lifecycle-viewmodel/src/main/java/androidx/hilt/lifecycle/HiltViewModelFactory.java
M hilt/integration-tests/viewmodelapp/build.gradle
A hilt/integration-tests/viewmodelapp/src/androidTest/java/androidx/hilt/integration/viewmodelapp/ActivityInjectionTest.kt
A hilt/integration-tests/viewmodelapp/src/androidTest/java/androidx/hilt/integration/viewmodelapp/BaseActivityInjectionTest.kt
A hilt/integration-tests/viewmodelapp/src/androidTest/java/androidx/hilt/integration/viewmodelapp/BaseFragmentInjectionTest.kt
A hilt/integration-tests/viewmodelapp/src/androidTest/java/androidx/hilt/integration/viewmodelapp/Bindings.kt
A hilt/integration-tests/viewmodelapp/src/androidTest/java/androidx/hilt/integration/viewmodelapp/FragmentInjectionTest.kt
A hilt/integration-tests/viewmodelapp/src/androidTest/java/androidx/hilt/integration/viewmodelapp/MyViewModels.kt
A hilt/integration-tests/viewmodelapp/src/androidTest/java/androidx/hilt/integration/viewmodelapp/TestRunner.kt
A hilt/integration-tests/viewmodelapp/src/debug/AndroidManifest.xml

https://android-review.googlesource.com/1339862

ma...@google.com <ma...@google.com> #4May 19, 2022 01:20PM

Reassigned to le...@google.com.

A fix for this will be available in alpha02

su...@gmail.com <su...@gmail.com> #5Jan 5, 2023 11:24AM

Any updates on this. We are facing same issue

[Deleted User] <[Deleted User]> #6Jan 5, 2023 11:35AM

facing same issue, please resolve it

uo...@google.com <uo...@google.com> May 15, 2023 01:32PM

Status: New

ma...@google.com <ma...@google.com> #7May 19, 2023 01:55PM

Status: Won't Fix (Not Reproducible)

Tried with recent compose 1.5 beta and I'm not able to reproduce this.

From the video, it seems like a lot of scroll-like gestures are brief touches instead of continuous scroll gestures.

Closing as WAI, but keep in mind that every finger is different and if you see the need for it - you could adjust the amount of vertical and horizontal touch slop needed to start either horiozntal or vertical gesture. You could do it by changing LocalViewConfiguration separately for vertical and horizontal scroll hierarchies. This way, you might control the angle at which compose disambiguates between horizontal and vertical scroll.

Doing so will result in different experiences for users in different apps, so use with caution.

uo...@google.com <uo...@google.com> May 19, 2023 02:46PM

Status: Won't Fix (Not Reproducible)

ji...@robinhood.com <ji...@robinhood.com> #8Mar 21, 2025 06:40PM

this is still an issue, by the way, even though this ticket is closed. it seems that the gesture handling logic won't handle a new gesture for vertical scroll if the previous horizontal scroll motion/fling hasn't settled / completed. I feel like it should be more natural for a new gesture (e.g. new down touch) interrupt the current animations and treat it as a new touch event series instead.

ji...@robinhood.com <ji...@robinhood.com> #9Mar 21, 2025 06:41PM

this becomes more problematic in a situation where you have one container that needs to handle gesture for both horizontal and vertical scroll because the different slop workaround won't work.

Issue 228754545

Description

Jetpack Compose version:

Jetpack Compose component used:

Android Studio Build:

Kotlin version:

Code Sample to Reproduce:

Steps to Reproduce

Issue summary

Comments

ch...@gmail.com <ch...@gmail.com> #2Apr 11, 2022 05:24AM

ae...@google.com <ae...@google.com> Apr 12, 2022 11:45PM

ga...@mistplay.com <ga...@mistplay.com> #3May 18, 2022 04:34PM

ma...@google.com <ma...@google.com> #4May 19, 2022 01:20PM

su...@gmail.com <su...@gmail.com> #5Jan 5, 2023 11:24AM

[Deleted User] <[Deleted User]> #6Jan 5, 2023 11:35AM

uo...@google.com <uo...@google.com> May 15, 2023 01:32PM

ma...@google.com <ma...@google.com> #7May 19, 2023 01:55PM

uo...@google.com <uo...@google.com> May 19, 2023 02:46PM

ji...@robinhood.com <ji...@robinhood.com> #8Mar 21, 2025 06:40PM

ji...@robinhood.com <ji...@robinhood.com> #9Mar 21, 2025 06:41PM

Add comment

Issue metadata